Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2647)

Unified Diff: chrome/chrome_dll.gypi

Issue 2008643002: Make chrome.exe/dll GN imports match GYP, remove user32 delay imports. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove more delay load stuff Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome.user32.delay.imports ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_dll.gypi
diff --git a/chrome/chrome_dll.gypi b/chrome/chrome_dll.gypi
index f5dcc8bd1ad4f5fdcac09f126dfb3adec8eb3351..86ae27d890b3a94433eea4ad2ccb726b7d2fd8c9 100644
--- a/chrome/chrome_dll.gypi
+++ b/chrome/chrome_dll.gypi
@@ -116,8 +116,6 @@
'app/chrome_main_delegate.h',
'app/chrome_main_mac.h',
'app/chrome_main_mac.mm',
- 'app/delay_load_hook_win.cc',
- 'app/delay_load_hook_win.h',
],
'dependencies': [
'<@(chromium_browser_dependencies)',
@@ -139,13 +137,6 @@
'../ui/compositor/compositor.gyp:compositor',
],
}],
- ['OS=="win" and target_arch=="ia32"', {
- # Add a dependency to custom import library for user32 delay
- # imports only in x86 builds.
- 'dependencies': [
- 'chrome_user32_delay_imports',
- ],
- },],
['OS=="win"', {
'product_name': 'chrome',
'dependencies': [
@@ -194,34 +185,6 @@
['target_arch=="ia32"', {
# Don't set an x64 base address (to avoid breaking HE-ASLR).
'BaseAddress': '0x01c30000',
- # Link against the XP-constrained user32 import library
- # instead of the platform-SDK provided one to avoid
- # inadvertently taking dependencies on post-XP user32
- # exports.
- 'AdditionalDependencies!': [
- 'user32.lib',
- ],
- 'IgnoreDefaultLibraryNames': [
- 'user32.lib',
- ],
- # Remove user32 delay load for chrome.dll.
- 'DelayLoadDLLs!': [
- 'user32.dll',
- ],
- 'AdditionalDependencies': [
- 'user32.winxp.lib',
- ],
- 'DelayLoadDLLs': [
- 'user32-delay.dll',
- ],
- 'AdditionalLibraryDirectories': [
- '<(DEPTH)/build/win/importlibs/x86',
- ],
- 'ForceSymbolReferences': [
- # Force the inclusion of the delay load hook in this
- # binary.
- '_ChromeDelayLoadHook@8',
- ],
}],
],
'DelayLoadDLLs': [
« no previous file with comments | « chrome/chrome.user32.delay.imports ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698