Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Side by Side Diff: chrome/chrome_dll.gypi

Issue 2008643002: Make chrome.exe/dll GN imports match GYP, remove user32 delay imports. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove more delay load stuff Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/chrome.user32.delay.imports ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 { 4 {
5 'conditions': [ 5 'conditions': [
6 # Dummy target to allow chrome to require chrome_dll to build 6 # Dummy target to allow chrome to require chrome_dll to build
7 # without actually linking to the library 7 # without actually linking to the library
8 ['OS=="mac"', { 8 ['OS=="mac"', {
9 'targets': [ 9 'targets': [
10 { 10 {
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 }, 109 },
110 'sources': [ 110 'sources': [
111 '../base/win/dllmain.cc', 111 '../base/win/dllmain.cc',
112 'app/chrome_command_ids.h', 112 'app/chrome_command_ids.h',
113 'app/chrome_dll_resource.h', 113 'app/chrome_dll_resource.h',
114 'app/chrome_main.cc', 114 'app/chrome_main.cc',
115 'app/chrome_main_delegate.cc', 115 'app/chrome_main_delegate.cc',
116 'app/chrome_main_delegate.h', 116 'app/chrome_main_delegate.h',
117 'app/chrome_main_mac.h', 117 'app/chrome_main_mac.h',
118 'app/chrome_main_mac.mm', 118 'app/chrome_main_mac.mm',
119 'app/delay_load_hook_win.cc',
120 'app/delay_load_hook_win.h',
121 ], 119 ],
122 'dependencies': [ 120 'dependencies': [
123 '<@(chromium_browser_dependencies)', 121 '<@(chromium_browser_dependencies)',
124 'chrome_features.gyp:chrome_common_features', 122 'chrome_features.gyp:chrome_common_features',
125 'policy_path_parser', 123 'policy_path_parser',
126 '../content/content.gyp:content_app_browser', 124 '../content/content.gyp:content_app_browser',
127 '../third_party/cld_2/cld_2.gyp:cld_2', 125 '../third_party/cld_2/cld_2.gyp:cld_2',
128 ], 126 ],
129 'conditions': [ 127 'conditions': [
130 ['OS=="win"', { 128 ['OS=="win"', {
131 'dependencies': [ 129 'dependencies': [
132 '<(DEPTH)/chrome_elf/chrome_elf.gyp:chrome_elf', 130 '<(DEPTH)/chrome_elf/chrome_elf.gyp:chrome_elf',
133 '<(DEPTH)/chrome/chrome.gyp:install_static_util', 131 '<(DEPTH)/chrome/chrome.gyp:install_static_util',
134 '<(DEPTH)/components/components.gyp:policy', 132 '<(DEPTH)/components/components.gyp:policy',
135 ], 133 ],
136 }], 134 }],
137 ['use_aura==1', { 135 ['use_aura==1', {
138 'dependencies': [ 136 'dependencies': [
139 '../ui/compositor/compositor.gyp:compositor', 137 '../ui/compositor/compositor.gyp:compositor',
140 ], 138 ],
141 }], 139 }],
142 ['OS=="win" and target_arch=="ia32"', {
143 # Add a dependency to custom import library for user32 delay
144 # imports only in x86 builds.
145 'dependencies': [
146 'chrome_user32_delay_imports',
147 ],
148 },],
149 ['OS=="win"', { 140 ['OS=="win"', {
150 'product_name': 'chrome', 141 'product_name': 'chrome',
151 'dependencies': [ 142 'dependencies': [
152 # On Windows, link the dependencies (libraries) that make 143 # On Windows, link the dependencies (libraries) that make
153 # up actual Chromium functionality into this .dll. 144 # up actual Chromium functionality into this .dll.
154 'chrome_version_resources', 145 'chrome_version_resources',
155 '../base/trace_event/etw_manifest/etw_manifest.gyp:etw_manifest' , 146 '../base/trace_event/etw_manifest/etw_manifest.gyp:etw_manifest' ,
156 '../chrome/chrome_resources.gyp:chrome_unscaled_resources', 147 '../chrome/chrome_resources.gyp:chrome_unscaled_resources',
157 '../content/app/resources/content_resources.gyp:content_resource s', 148 '../content/app/resources/content_resources.gyp:content_resource s',
158 '../crypto/crypto.gyp:crypto', 149 '../crypto/crypto.gyp:crypto',
(...skipping 28 matching lines...) Expand all
187 # Set /SUBSYSTEM:WINDOWS for chrome.dll (for consistency). 178 # Set /SUBSYSTEM:WINDOWS for chrome.dll (for consistency).
188 'SubSystem': '2', 179 'SubSystem': '2',
189 'conditions': [ 180 'conditions': [
190 ['incremental_chrome_dll==1', { 181 ['incremental_chrome_dll==1', {
191 'OutputFile': '$(OutDir)\\initial\\chrome.dll', 182 'OutputFile': '$(OutDir)\\initial\\chrome.dll',
192 'UseLibraryDependencyInputs': "true", 183 'UseLibraryDependencyInputs': "true",
193 }], 184 }],
194 ['target_arch=="ia32"', { 185 ['target_arch=="ia32"', {
195 # Don't set an x64 base address (to avoid breaking HE-ASLR ). 186 # Don't set an x64 base address (to avoid breaking HE-ASLR ).
196 'BaseAddress': '0x01c30000', 187 'BaseAddress': '0x01c30000',
197 # Link against the XP-constrained user32 import library
198 # instead of the platform-SDK provided one to avoid
199 # inadvertently taking dependencies on post-XP user32
200 # exports.
201 'AdditionalDependencies!': [
202 'user32.lib',
203 ],
204 'IgnoreDefaultLibraryNames': [
205 'user32.lib',
206 ],
207 # Remove user32 delay load for chrome.dll.
208 'DelayLoadDLLs!': [
209 'user32.dll',
210 ],
211 'AdditionalDependencies': [
212 'user32.winxp.lib',
213 ],
214 'DelayLoadDLLs': [
215 'user32-delay.dll',
216 ],
217 'AdditionalLibraryDirectories': [
218 '<(DEPTH)/build/win/importlibs/x86',
219 ],
220 'ForceSymbolReferences': [
221 # Force the inclusion of the delay load hook in this
222 # binary.
223 '_ChromeDelayLoadHook@8',
224 ],
225 }], 188 }],
226 ], 189 ],
227 'DelayLoadDLLs': [ 190 'DelayLoadDLLs': [
228 'comdlg32.dll', 191 'comdlg32.dll',
229 'crypt32.dll', 192 'crypt32.dll',
230 'cryptui.dll', 193 'cryptui.dll',
231 'dhcpcsvc.dll', 194 'dhcpcsvc.dll',
232 'imagehlp.dll', 195 'imagehlp.dll',
233 'imm32.dll', 196 'imm32.dll',
234 'iphlpapi.dll', 197 'iphlpapi.dll',
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
396 'dependencies': [ 359 'dependencies': [
397 '../pdf/pdf.gyp:pdf', 360 '../pdf/pdf.gyp:pdf',
398 ], 361 ],
399 }], 362 }],
400 ], 363 ],
401 }, # target chrome_child_dll 364 }, # target chrome_child_dll
402 ], 365 ],
403 }], 366 }],
404 ], 367 ],
405 } 368 }
OLDNEW
« no previous file with comments | « chrome/chrome.user32.delay.imports ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698