Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: chrome/BUILD.gn

Issue 2008643002: Make chrome.exe/dll GN imports match GYP, remove user32 delay imports. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove more delay load stuff Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/win/importlibs/x86/user32.winxp.lib ('k') | chrome/app/delay_load_hook_unittest_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/features.gni") 8 import("//build/config/features.gni")
9 import("//build/config/locales.gni") 9 import("//build/config/locales.gni")
10 import("//build/config/sanitizers/sanitizers.gni") 10 import("//build/config/sanitizers/sanitizers.gni")
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 ] 148 ]
149 149
150 if (win_console_app) { 150 if (win_console_app) {
151 defines += [ "WIN_CONSOLE_APP" ] 151 defines += [ "WIN_CONSOLE_APP" ]
152 } else { 152 } else {
153 # Set /SUBSYSTEM:WINDOWS for chrome.exe itself, unless a console build 153 # Set /SUBSYSTEM:WINDOWS for chrome.exe itself, unless a console build
154 # has been requested. 154 # has been requested.
155 configs -= [ "//build/config/win:console" ] 155 configs -= [ "//build/config/win:console" ]
156 configs += [ "//build/config/win:windowed" ] 156 configs += [ "//build/config/win:windowed" ]
157 } 157 }
158
159 ldflags = [
160 "/DELAYLOAD:dbghelp.dll",
161 "/DELAYLOAD:dwmapi.dll",
162 "/DELAYLOAD:uxtheme.dll",
163 "/DELAYLOAD:ole32.dll",
164 "/DELAYLOAD:oleaut32.dll",
165 ]
158 } else if (use_aura) { 166 } else if (use_aura) {
159 # Non-Windows aura entrypoint. 167 # Non-Windows aura entrypoint.
160 sources += [ "app/chrome_exe_main_aura.cc" ] 168 sources += [ "app/chrome_exe_main_aura.cc" ]
161 } 169 }
162 170
163 if (is_linux) { 171 if (is_linux) {
164 sources += [ 172 sources += [
165 "app/chrome_dll_resource.h", 173 "app/chrome_dll_resource.h",
166 "app/chrome_main.cc", 174 "app/chrome_main.cc",
167 "app/chrome_main_delegate.cc", 175 "app/chrome_main_delegate.cc",
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
256 sources = [ 264 sources = [
257 "//base/win/dllmain.cc", 265 "//base/win/dllmain.cc",
258 "app/chrome_command_ids.h", 266 "app/chrome_command_ids.h",
259 "app/chrome_dll.rc", 267 "app/chrome_dll.rc",
260 "app/chrome_dll_resource.h", 268 "app/chrome_dll_resource.h",
261 "app/chrome_main.cc", 269 "app/chrome_main.cc",
262 "app/chrome_main_delegate.cc", 270 "app/chrome_main_delegate.cc",
263 "app/chrome_main_delegate.h", 271 "app/chrome_main_delegate.h",
264 "app/chrome_main_mac.h", 272 "app/chrome_main_mac.h",
265 "app/chrome_main_mac.mm", 273 "app/chrome_main_mac.mm",
266 "app/delay_load_hook_win.cc",
267 "app/delay_load_hook_win.h",
268 ] 274 ]
269 275
270 deps = [ 276 deps = [
271 ":browser_dependencies", 277 ":browser_dependencies",
272 "//build/config/sanitizers:deps", 278 "//build/config/sanitizers:deps",
273 "//chrome/common:features", 279 "//chrome/common:features",
274 "//third_party/cld_2", 280 "//third_party/cld_2",
275 ] 281 ]
276 if (is_win) { 282 if (is_win) {
277 output_name = "chrome" 283 output_name = "chrome"
278 284
279 deps += [ 285 deps += [
280 ":chrome_dll_manifest", 286 ":chrome_dll_manifest",
281 ":chrome_dll_version", 287 ":chrome_dll_version",
282 "//base/trace_event/etw_manifest:chrome_events_win", 288 "//base/trace_event/etw_manifest:chrome_events_win",
283 "//chrome/app/theme:chrome_unscaled_resources", 289 "//chrome/app/theme:chrome_unscaled_resources",
284 "//chrome/install_static:install_static_util", 290 "//chrome/install_static:install_static_util",
285 "//chrome_elf", 291 "//chrome_elf",
286 "//components/crash/content/app", 292 "//components/crash/content/app",
287 "//components/policy", 293 "//components/policy",
288 "//content/app/resources", 294 "//content/app/resources",
289 "//crypto", 295 "//crypto",
290 "//net:net_resources", 296 "//net:net_resources",
291 "//third_party/wtl", 297 "//third_party/wtl",
292 "//ui/views", 298 "//ui/views",
293 ] 299 ]
294 if (current_cpu == "x86") { 300
295 # TODO(GYP) bug 512861: Lots of VCLinkerTool stuff on Windows. 301 ldflags += [
296 #deps += [ 'chrome_user32_delay_imports' ] TODO(GYP) 302 "/DELAYLOAD:comdlg32.dll",
297 } 303 "/DELAYLOAD:crypt32.dll",
304 "/DELAYLOAD:cryptui.dll",
305 "/DELAYLOAD:dhcpcsvc.dll",
306 "/DELAYLOAD:imagehlp.dll",
307 "/DELAYLOAD:imm32.dll",
308 "/DELAYLOAD:iphlpapi.dll",
309 "/DELAYLOAD:setupapi.dll",
310 "/DELAYLOAD:urlmon.dll",
311 "/DELAYLOAD:winhttp.dll",
312 "/DELAYLOAD:wininet.dll",
313 "/DELAYLOAD:winspool.drv",
314 "/DELAYLOAD:ws2_32.dll",
315 "/DELAYLOAD:wsock32.dll",
316 ]
298 317
299 # This is a large module that can't do incremental linking in some cases. 318 # This is a large module that can't do incremental linking in some cases.
300 configs -= [ "//build/config/win:default_incremental_linking" ] 319 configs -= [ "//build/config/win:default_incremental_linking" ]
301 configs += 320 configs +=
302 [ "//build/config/win:default_large_module_incremental_linking" ] 321 [ "//build/config/win:default_large_module_incremental_linking" ]
303 } 322 }
304 323
305 if (use_aura) { 324 if (use_aura) {
306 deps += [ "//ui/compositor" ] 325 deps += [ "//ui/compositor" ]
307 } 326 }
(...skipping 1230 matching lines...) Expand 10 before | Expand all | Expand 10 after
1538 "//chrome/app/theme/$branding_path_component/product_logo_48.png", 1557 "//chrome/app/theme/$branding_path_component/product_logo_48.png",
1539 "//chrome/tools/build/linux/chrome-wrapper", 1558 "//chrome/tools/build/linux/chrome-wrapper",
1540 "//third_party/xdg-utils/scripts/xdg-mime", 1559 "//third_party/xdg-utils/scripts/xdg-mime",
1541 "//third_party/xdg-utils/scripts/xdg-settings", 1560 "//third_party/xdg-utils/scripts/xdg-settings",
1542 ] 1561 ]
1543 outputs = [ 1562 outputs = [
1544 "$root_out_dir/{{source_file_part}}", 1563 "$root_out_dir/{{source_file_part}}",
1545 ] 1564 ]
1546 } 1565 }
1547 } 1566 }
OLDNEW
« no previous file with comments | « build/win/importlibs/x86/user32.winxp.lib ('k') | chrome/app/delay_load_hook_unittest_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698