Make chrome.exe/dll GN imports match GYP, remove user32 delay imports.

Remove user32 delay imports for XP, more GN imports match GYP.

This delay loads additional libraries so the set of delay-loaded and non-delay-loaded libraries is the same between GYP and GN for 32-bit Windows official builds of chrome.exe and chrome.dll. I checked the imported libraries but not the individual functions.

Remove user32 delay imports. This was a hack for Windows XP. I checked all the functions in the list of imports and they are all available on Windows 7. There was a lot of machinery required for this that was removed.

BUG=512861
Reland of https://crrev.com/080e7e885be49295f8373eb0fa54e6772206bc64 with fix.

Committed: https://crrev.com/cc84b6cdb2ba06927c498632c86cb0c81e50e9ec
Cr-Commit-Position: refs/heads/master@{#395432}

[brettw, 2016-05-23 19:39:56]

Description was changed from

==========
Make chrome.exe/dll GN imports match GYP, remove user32 delay imports.

This delay loads additional libraries so the set of delay-loaded and
non-delay-loaded libraries is the same between GYP and GN for 32-bit Windows
official builds of chrome.exe and chrome.dll. I checked the imported libraries
but not the individual functions.

Remove user32 delay imports. This was a hack for Windows XP. I checked all the
functions in the list of imports and they are all available on Windows 7.

BUG=512861
Reland of https://crrev.com/080e7e885be49295f8373eb0fa54e6772206bc64 with fix.
==========

to

==========
Remove user32 delay imports for XP, more GN imports match GYP.

This delay loads additional libraries so the set of delay-loaded and
non-delay-loaded libraries is the same between GYP and GN for 32-bit Windows
official builds of chrome.exe and chrome.dll. I checked the imported libraries
but not the individual functions.

Remove user32 delay imports. This was a hack for Windows XP. I checked all the
functions in the list of imports and they are all available on Windows 7. There
was a lot of machinery required for this that was removed.

BUG=512861
Reland of https://crrev.com/080e7e885be49295f8373eb0fa54e6772206bc64 with fix.
==========

[brettw, 2016-05-23 19:39:57]

brettw@chromium.org changed reviewers:
+ brucedawson@chromium.org

[brettw, 2016-05-23 19:41:32]

The previous landing removed our delay load hook, but kept the stuff that
prevented us from linking to user32, so links failed.

Tracking that down led to finding a lot of stuff supporting this delay loading
hack for XP that can now be removed, so the new patch removes a lot more stuff.

[brettw, 2016-05-23 19:41:36]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-23 19:41:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2008643002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2008643002/20001

[commit-bot: I haz the power, 2016-05-23 20:43:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-23 20:43:13]

Dry run: This issue passed the CQ dry run.

[brucedawson, 2016-05-23 21:15:03]

That does get rid of a lot more stuff. lgtm.

[brettw, 2016-05-23 22:07:18]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-05-23 22:08:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2008643002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2008643002/20001

[commit-bot: I haz the power, 2016-05-23 22:13:26]

Description was changed from

==========
Remove user32 delay imports for XP, more GN imports match GYP.

This delay loads additional libraries so the set of delay-loaded and
non-delay-loaded libraries is the same between GYP and GN for 32-bit Windows
official builds of chrome.exe and chrome.dll. I checked the imported libraries
but not the individual functions.

Remove user32 delay imports. This was a hack for Windows XP. I checked all the
functions in the list of imports and they are all available on Windows 7. There
was a lot of machinery required for this that was removed.

BUG=512861
Reland of https://crrev.com/080e7e885be49295f8373eb0fa54e6772206bc64 with fix.
==========

to

==========
Remove user32 delay imports for XP, more GN imports match GYP.

This delay loads additional libraries so the set of delay-loaded and
non-delay-loaded libraries is the same between GYP and GN for 32-bit Windows
official builds of chrome.exe and chrome.dll. I checked the imported libraries
but not the individual functions.

Remove user32 delay imports. This was a hack for Windows XP. I checked all the
functions in the list of imports and they are all available on Windows 7. There
was a lot of machinery required for this that was removed.

BUG=512861
Reland of https://crrev.com/080e7e885be49295f8373eb0fa54e6772206bc64 with fix.
==========

[commit-bot: I haz the power, 2016-05-23 22:13:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-23 22:15:09]

Description was changed from

==========
Remove user32 delay imports for XP, more GN imports match GYP.

This delay loads additional libraries so the set of delay-loaded and
non-delay-loaded libraries is the same between GYP and GN for 32-bit Windows
official builds of chrome.exe and chrome.dll. I checked the imported libraries
but not the individual functions.

Remove user32 delay imports. This was a hack for Windows XP. I checked all the
functions in the list of imports and they are all available on Windows 7. There
was a lot of machinery required for this that was removed.

BUG=512861
Reland of https://crrev.com/080e7e885be49295f8373eb0fa54e6772206bc64 with fix.
==========

to

==========
Remove user32 delay imports for XP, more GN imports match GYP.

This delay loads additional libraries so the set of delay-loaded and
non-delay-loaded libraries is the same between GYP and GN for 32-bit Windows
official builds of chrome.exe and chrome.dll. I checked the imported libraries
but not the individual functions.

Remove user32 delay imports. This was a hack for Windows XP. I checked all the
functions in the list of imports and they are all available on Windows 7. There
was a lot of machinery required for this that was removed.

BUG=512861
Reland of https://crrev.com/080e7e885be49295f8373eb0fa54e6772206bc64 with fix.

Committed: https://crrev.com/cc84b6cdb2ba06927c498632c86cb0c81e50e9ec
Cr-Commit-Position: refs/heads/master@{#395432}
==========

[commit-bot: I haz the power, 2016-05-23 22:15:11]

Patchset 2 (id:??) landed as
https://crrev.com/cc84b6cdb2ba06927c498632c86cb0c81e50e9ec
Cr-Commit-Position: refs/heads/master@{#395432}

[scottmg, 2016-05-24 16:50:28]

Nice!