Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2008583004: Disabling HD video quality tests on win7. (Closed)

Created:
4 years, 7 months ago by phoglund_chromium
Modified:
4 years, 7 months ago
Reviewers:
hbos_chromium
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, tnakamura+watch_chromium.org, phoglund+watch_chromium.org, mcasas+watch+vc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disabling HD video quality tests on win7. A labs engineer probably needs to look at the GL drivers on the bot. The problem only affects HD tests on Win 7. BUG=613947 R=hbos@chromium.org Committed: https://crrev.com/9547bb36ce85227ef99e6ac31d923669d97b2177 Cr-Commit-Position: refs/heads/master@{#395562}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/browser/media/webrtc_video_quality_browsertest.cc View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
phoglund_chromium
4 years, 7 months ago (2016-05-24 08:36:36 UTC) #1
hbos_chromium
How did you deduce that this is only a problem if hd?
4 years, 7 months ago (2016-05-24 09:01:26 UTC) #2
hbos_chromium
Nevermind, I just read what you wrote on the bug. LGTM.
4 years, 7 months ago (2016-05-24 09:12:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008583004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008583004/1
4 years, 7 months ago (2016-05-24 09:19:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 10:57:12 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9547bb36ce85227ef99e6ac31d923669d97b2177 Cr-Commit-Position: refs/heads/master@{#395562}
4 years, 7 months ago (2016-05-24 10:59:15 UTC) #10
phoglund_chromium
4 years, 6 months ago (2016-06-02 10:25:42 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2032993002/ by phoglund@chromium.org.

The reason for reverting is: The charCode regression has been fixed, so the
tests should work now..

Powered by Google App Engine
This is Rietveld 408576698