Remove CFX_PrivateData from CPDF_Page

Remove CFX_PrivateData from CPDF_Page

CFX_PrivateData served two purposes here:

The first was to hold an opaque pointer to the corresponding
page structure in the next higher layer, of which it knows
no details.  Introduce an empty CPDF_Page::View class to
represent this higher class, so as to get type safety while
preserving layering.

The second was to hold an opaque render context, which it 
also happened to own.  Make this a CFX_Deletable to help 
with management.

Also remove an unused inheritance from CFX_PrivateData
in CPDF_Annot.

Committed: https://pdfium.googlesource.com/pdfium/+/1e2c557e0fa0e47c8bafdb31c833ea4f90f5fedd

[Tom Sepez, 2016-05-25 00:01:44]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-05-25 00:01:44]

Lei, for review.

[Lei Zhang, 2016-05-25 01:25:18]

lgtm

[Tom Sepez, 2016-05-25 20:32:20]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-05-25 20:32:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2008553008/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2008553008/1

[commit-bot: I haz the power, 2016-05-25 20:34:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-25 20:34:35]

Try jobs failed on following builders:
  mac_no_v8 on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/mac_no_v8/build...)
  win on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win/builds/769)

[Tom Sepez, 2016-05-25 21:42:19]

Description was changed from

==========
Remove CFX_PrivateData from CPDF_Page

Also remove an unused inheritance from CFX_PrivateData
in CPDF_Annot.  Require that the otherwise opaque context
held by the page be deletable.
==========

to

==========
Remove CFX_PrivateData from CPDF_Page

CFX_PrivateData server two purposes.

The first was to hold an opaque pointer to the corresponding page
structure in the next higher layer, of which it knows no details.  Introduce an
empty CPDF_Page::View class to represent this higher class, so as to get type
safety while
preserving layering.

The second was to hold an opaque render context, which it also happened to own. 
Make this a CFX_Deletable to help with management.
Also remove an unused inheritance from CFX_PrivateData
in CPDF_Annot.
==========

[Tom Sepez, 2016-05-25 21:42:52]

Description was changed from

==========
Remove CFX_PrivateData from CPDF_Page

CFX_PrivateData server two purposes.

The first was to hold an opaque pointer to the corresponding page
structure in the next higher layer, of which it knows no details.  Introduce an
empty CPDF_Page::View class to represent this higher class, so as to get type
safety while
preserving layering.

The second was to hold an opaque render context, which it also happened to own. 
Make this a CFX_Deletable to help with management.
Also remove an unused inheritance from CFX_PrivateData
in CPDF_Annot.
==========

to

==========
Remove CFX_PrivateData from CPDF_Page

CFX_PrivateData server two purposes.

The first was to hold an opaque pointer to the corresponding
page structure in the next higher layer, of which it knows no details. 
Introduce an empty CPDF_Page::View class to
represent this higher class, so as to get type safety while
preserving layering.

The second was to hold an opaque render context, which it also happened to own. 
Make this a CFX_Deletable to help with management.
Also remove an unused inheritance from CFX_PrivateData
in CPDF_Annot.
==========

[Tom Sepez, 2016-05-25 21:43:49]

Description was changed from

==========
Remove CFX_PrivateData from CPDF_Page

CFX_PrivateData server two purposes.

The first was to hold an opaque pointer to the corresponding
page structure in the next higher layer, of which it knows no details. 
Introduce an empty CPDF_Page::View class to
represent this higher class, so as to get type safety while
preserving layering.

The second was to hold an opaque render context, which it also happened to own. 
Make this a CFX_Deletable to help with management.
Also remove an unused inheritance from CFX_PrivateData
in CPDF_Annot.
==========

to

==========
Remove CFX_PrivateData from CPDF_Page

CFX_PrivateData server two purposes.

The first was to hold an opaque pointer to the corresponding
page structure in the next higher layer, of which it knows
no details.  Introduce an empty CPDF_Page::View class to
represent this higher class, so as to get type safety while
preserving layering.

The second was to hold an opaque render context, which it 
also happened to own.  Make this a CFX_Deletable to help 
with management.

Also remove an unused inheritance from CFX_PrivateData
in CPDF_Annot.
==========

[Tom Sepez, 2016-05-25 21:45:10]

Lei, please re-review.  I had to add some code to cover one usage in the non-xfa
case.  See the updated CL description for details.

[Tom Sepez, 2016-05-25 21:45:25]

Description was changed from

==========
Remove CFX_PrivateData from CPDF_Page

CFX_PrivateData server two purposes.

The first was to hold an opaque pointer to the corresponding
page structure in the next higher layer, of which it knows
no details.  Introduce an empty CPDF_Page::View class to
represent this higher class, so as to get type safety while
preserving layering.

The second was to hold an opaque render context, which it 
also happened to own.  Make this a CFX_Deletable to help 
with management.

Also remove an unused inheritance from CFX_PrivateData
in CPDF_Annot.
==========

to

==========
Remove CFX_PrivateData from CPDF_Page

CFX_PrivateData served two purposes here:

The first was to hold an opaque pointer to the corresponding
page structure in the next higher layer, of which it knows
no details.  Introduce an empty CPDF_Page::View class to
represent this higher class, so as to get type safety while
preserving layering.

The second was to hold an opaque render context, which it 
also happened to own.  Make this a CFX_Deletable to help 
with management.

Also remove an unused inheritance from CFX_PrivateData
in CPDF_Annot.
==========

[Lei Zhang, 2016-05-25 21:50:24]

lgtm

[Tom Sepez, 2016-05-25 21:57:46]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-05-25 21:57:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2008553008/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2008553008/20001

[commit-bot: I haz the power, 2016-05-25 21:58:13]

Description was changed from

==========
Remove CFX_PrivateData from CPDF_Page

CFX_PrivateData served two purposes here:

The first was to hold an opaque pointer to the corresponding
page structure in the next higher layer, of which it knows
no details.  Introduce an empty CPDF_Page::View class to
represent this higher class, so as to get type safety while
preserving layering.

The second was to hold an opaque render context, which it 
also happened to own.  Make this a CFX_Deletable to help 
with management.

Also remove an unused inheritance from CFX_PrivateData
in CPDF_Annot.
==========

to

==========
Remove CFX_PrivateData from CPDF_Page

CFX_PrivateData served two purposes here:

The first was to hold an opaque pointer to the corresponding
page structure in the next higher layer, of which it knows
no details.  Introduce an empty CPDF_Page::View class to
represent this higher class, so as to get type safety while
preserving layering.

The second was to hold an opaque render context, which it 
also happened to own.  Make this a CFX_Deletable to help 
with management.

Also remove an unused inheritance from CFX_PrivateData
in CPDF_Annot.

Committed:
https://pdfium.googlesource.com/pdfium/+/1e2c557e0fa0e47c8bafdb31c833ea4f90f5...
==========

[commit-bot: I haz the power, 2016-05-25 21:58:15]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/1e2c557e0fa0e47c8bafdb31c833ea4f90f5...