Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2008553006: Add 'Flog' formatted logging to mojo/services (Closed)

Created:
4 years, 7 months ago by dalesat
Modified:
4 years, 7 months ago
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add 'Flog' formatted logging to mojo/services Introduces service definitions for 'Flog' (formatting logging) and associated C++ library for adding log generation to services and applications. No logging service is implemented yet, just the stuff needed to annotate code that needs to generate log messages. R=kulakowski@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/17dd2f6df02650b221769d39c55857e06602a733

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2530 lines, -1251 lines) Patch
A mojo/dart/packages/mojo_services/lib/mojo/flog/flog.mojom.dart View 1 chunk +2164 lines, -0 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/audio_track.mojom.dart View 4 chunks +5 lines, -5 lines 0 comments Download
D mojo/dart/packages/mojo_services/lib/mojo/media/rate_control.mojom.dart View 1 chunk +0 lines, -1235 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/timeline_controller.mojom.dart View 3 chunks +42 lines, -4 lines 0 comments Download
A + mojo/services/flog/cpp/BUILD.gn View 1 chunk +7 lines, -5 lines 0 comments Download
A mojo/services/flog/cpp/flog.h View 1 chunk +197 lines, -0 lines 0 comments Download
A mojo/services/flog/cpp/flog.cc View 1 chunk +37 lines, -0 lines 0 comments Download
A + mojo/services/flog/interfaces/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
A mojo/services/flog/interfaces/flog.mojom View 1 chunk +75 lines, -0 lines 0 comments Download
M mojo/services/mojo_services.gni View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
dalesat
Please take a look. Thanks!
4 years, 7 months ago (2016-05-24 20:03:47 UTC) #3
kulakowski
lgtm
4 years, 7 months ago (2016-05-24 22:09:26 UTC) #4
dalesat
Committed patchset #1 (id:1) manually as 17dd2f6df02650b221769d39c55857e06602a733 (presubmit successful).
4 years, 7 months ago (2016-05-24 22:33:25 UTC) #6
viettrungluu
4 years, 7 months ago (2016-05-25 16:31:28 UTC) #8
Message was sent while issue was closed.
We already have a logging service. Why do we need two?

If it needs additional capabilities (which is certainly a reasonable thing to
want), then that should be discussed.

Powered by Google App Engine
This is Rietveld 408576698