Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2008553002: Functions only called by DumpFreeSpace need to be conditionally compiled. (Closed)

Created:
4 years, 7 months ago by Tobias Sargeant
Modified:
4 years, 7 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Functions only called by DumpFreeSpace need to be conditionally compiled. BUG=525938 R=mark@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/faeb1f9b2b45cd4e0bee0a677076cbe962034b75

Patch Set 1 #

Total comments: 1

Patch Set 2 : comment endif #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/client/linux/microdump_writer/microdump_writer.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Tobias Sargeant
4 years, 7 months ago (2016-05-23 17:42:25 UTC) #2
Mark Mentovai
LGTM https://codereview.chromium.org/2008553002/diff/1/src/client/linux/microdump_writer/microdump_writer.cc File src/client/linux/microdump_writer/microdump_writer.cc (right): https://codereview.chromium.org/2008553002/diff/1/src/client/linux/microdump_writer/microdump_writer.cc#newcode129 src/client/linux/microdump_writer/microdump_writer.cc:129: #endif #endif // !__LP64__
4 years, 7 months ago (2016-05-23 17:51:11 UTC) #4
Tobias Sargeant
4 years, 7 months ago (2016-05-23 17:58:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
faeb1f9b2b45cd4e0bee0a677076cbe962034b75 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698