Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 2008543007: Revert of [gn] Add cctest (Closed)

Created:
4 years, 7 months ago by Michael Hablich
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, jochen (gone - plz use gerrit)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [gn] Add cctest (patchset #1 id:1 of https://codereview.chromium.org/2007143003/ ) Reason for revert: Reason for revert: Speculative revert because of roll block: https://codereview.chromium.org/2004203004/ Original issue's description: > [gn] Add cctest > > BUG=chromium:474921 > NOTRY=true > > Committed: https://crrev.com/52a6fced896e3f64ac56eb57bcdea78393642e0c > Cr-Commit-Position: refs/heads/master@{#36517} TBR=vogelheim@chromium.org,machenbach@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:474921 Committed: https://crrev.com/73db38c5c528719debfc688f3eeb7b445a810900 Cr-Commit-Position: refs/heads/master@{#36520}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -352 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D test/cctest/BUILD.gn View 1 chunk +0 lines, -351 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Hablich
Created Revert of [gn] Add cctest
4 years, 7 months ago (2016-05-25 15:19:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008543007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008543007/1
4 years, 7 months ago (2016-05-25 15:19:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 15:19:54 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/73db38c5c528719debfc688f3eeb7b445a810900 Cr-Commit-Position: refs/heads/master@{#36520}
4 years, 7 months ago (2016-05-25 15:21:15 UTC) #6
Michael Achenbach
4 years, 7 months ago (2016-05-27 06:12:12 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698