Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2008473004: Adding another test expectations for Android. (Closed)

Created:
4 years, 7 months ago by cblume
Modified:
4 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding another test expectations for Android. Nexus 6: Skipping: conformance/glsl/misc/shader-struct-scope.html Failing: conformance/glsl/misc/shaders-with-invariance.html conformance/rendering/gl-viewport-test.html conformance/textures/svg_image/tex-2d-rgb-rgb-unsigned_byte.html conformance/textures/svg_image/tex-2d-rgb-rgb-unsigned_short_5_6_5.html conformance/textures/svg_image/tex-2d-rgba-rgba-unsigned_byte.html conformance/textures/svg_image/tex-2d-rgba-rgba-unsigned_short_4_4_4_4.html conformance/textures/svg_image/tex-2d-rgba-rgba-unsigned_short_5_5_5_1.html deqp/data/gles2/shaders/preprocessor.html BUG=611945 R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/682763ef4610d910c98cf45e178cd1fba4f68231 Cr-Commit-Position: refs/heads/master@{#395798}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Adding comment and bug for special error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -9 lines) Patch
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 1 chunk +19 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
cblume
PTAL
4 years, 7 months ago (2016-05-24 08:29:40 UTC) #2
Ken Russell (switch to Gerrit)
lgtm https://codereview.chromium.org/2008473004/diff/1/content/test/gpu/gpu_tests/webgl_conformance_expectations.py File content/test/gpu/gpu_tests/webgl_conformance_expectations.py (right): https://codereview.chromium.org/2008473004/diff/1/content/test/gpu/gpu_tests/webgl_conformance_expectations.py#newcode329 content/test/gpu/gpu_tests/webgl_conformance_expectations.py:329: self.Skip('conformance/glsl/misc/shader-struct-scope.html', I think this one in particular should ...
4 years, 7 months ago (2016-05-24 23:12:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008473004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008473004/20001
4 years, 7 months ago (2016-05-25 00:24:09 UTC) #6
cblume
https://codereview.chromium.org/2008473004/diff/1/content/test/gpu/gpu_tests/webgl_conformance_expectations.py File content/test/gpu/gpu_tests/webgl_conformance_expectations.py (right): https://codereview.chromium.org/2008473004/diff/1/content/test/gpu/gpu_tests/webgl_conformance_expectations.py#newcode329 content/test/gpu/gpu_tests/webgl_conformance_expectations.py:329: self.Skip('conformance/glsl/misc/shader-struct-scope.html', On 2016/05/24 23:12:16, Ken Russell wrote: > I ...
4 years, 7 months ago (2016-05-25 00:24:49 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/234934)
4 years, 7 months ago (2016-05-25 01:56:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008473004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008473004/20001
4 years, 7 months ago (2016-05-25 03:20:52 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-25 04:17:24 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 04:18:36 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/682763ef4610d910c98cf45e178cd1fba4f68231
Cr-Commit-Position: refs/heads/master@{#395798}

Powered by Google App Engine
This is Rietveld 408576698