Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2008473002: Revert of H264POC: Allow gaps in frame_num. (Closed)

Created:
4 years, 7 months ago by rnephew (Reviews Here)
Modified:
4 years, 7 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of H264POC: Allow gaps in frame_num. (patchset #4 id:60001 of https://codereview.chromium.org/1967893002/ ) Reason for revert: Causing perf test failure on mac. crbug.com/614023 Original issue's description: > H264POC: Allow gaps in frame_num. > > This change only removes the restriction, it does not try to detect > all the cases where doing so is likely to result in problems. In most > cases (specifically, those where the number of missing frames is much > less than max_frame_num), the result will be correct. > > In incorrect cases the reorder queue could get confused and result in > strange playback. The existing TODOs for the reorder queue explain how > to reduce that, but also inserting dummy frames for gaps would help as > well. > > BUG=550854 > > Committed: https://crrev.com/b6f4380493084007dc4237d28153c0dd3e5d520b > Cr-Commit-Position: refs/heads/master@{#395164} TBR=posciak@chromium.org,sandersd@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=550854 Committed: https://crrev.com/86f1678a243f90e8767c73eed5870ee9986da36e Cr-Commit-Position: refs/heads/master@{#395338}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -29 lines) Patch
M media/gpu/vt_video_decode_accelerator_mac.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/video/h264_poc.cc View 2 chunks +3 lines, -12 lines 0 comments Download
M media/video/h264_poc_unittest.cc View 3 chunks +5 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
rnephew (Reviews Here)
Created Revert of H264POC: Allow gaps in frame_num.
4 years, 7 months ago (2016-05-23 14:14:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008473002/1
4 years, 7 months ago (2016-05-23 14:14:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008473002/1
4 years, 7 months ago (2016-05-23 14:31:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008473002/1
4 years, 7 months ago (2016-05-23 15:01:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008473002/1
4 years, 7 months ago (2016-05-23 15:31:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008473002/1
4 years, 7 months ago (2016-05-23 16:01:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008473002/1
4 years, 7 months ago (2016-05-23 16:31:12 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-23 16:36:02 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 16:37:23 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/86f1678a243f90e8767c73eed5870ee9986da36e
Cr-Commit-Position: refs/heads/master@{#395338}

Powered by Google App Engine
This is Rietveld 408576698