Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 20084003: Add --trace-hydrogen-stubs flag (default = false). (Closed)

Created:
7 years, 5 months ago by titzer
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add --trace-hydrogen-stubs flag (default = false). BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15859

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix tracing of stubs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M src/code-stubs-hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.cc View 1 1 chunk +7 lines, -4 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
titzer
7 years, 5 months ago (2013-07-24 11:29:43 UTC) #1
Michael Starzinger
https://codereview.chromium.org/20084003/diff/1/src/compiler.cc File src/compiler.cc (right): https://codereview.chromium.org/20084003/diff/1/src/compiler.cc#newcode1252 src/compiler.cc:1252: return ((FLAG_trace_hydrogen || FLAG_trace_hydrogen_stubs) && IIUC, this will still ...
7 years, 5 months ago (2013-07-24 12:03:54 UTC) #2
Michael Starzinger
LGTM.
7 years, 5 months ago (2013-07-24 12:32:06 UTC) #3
titzer
7 years, 5 months ago (2013-07-24 12:39:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r15859 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698