Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2008383002: Remove a bunch of stuff in //mojo (Closed)

Created:
4 years, 7 months ago by Ben Goodger (Google)
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a bunch of stuff in //mojo R=rockot@chromium.org http://crbug.com/608017 Committed: https://crrev.com/ba768a8531c059ae32a71b4cb18163f174110688 Cr-Commit-Position: refs/heads/master@{#396079}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -398 lines) Patch
M components/filesystem/directory_impl_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M components/filesystem/file_impl_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M components/filesystem/files_test_base.h View 5 6 7 1 chunk +22 lines, -0 lines 0 comments Download
M components/filesystem/files_test_base.cc View 1 2 3 4 2 chunks +1 line, -2 lines 0 comments Download
M components/leveldb/leveldb_service_unittest.cc View 1 2 3 4 5 6 7 2 chunks +14 lines, -3 lines 0 comments Download
M components/leveldb/remote_iterator_unittest.cc View 1 2 3 4 5 6 7 1 chunk +5 lines, -3 lines 0 comments Download
M content/browser/webui/web_ui_mojo_browsertest.cc View 1 2 3 3 chunks +12 lines, -5 lines 0 comments Download
M content/content_tests.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M media/mojo/services/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M media/mojo/services/main.cc View 1 2 3 4 5 6 2 chunks +5 lines, -2 lines 0 comments Download
D mojo/build/package_app.gypi View 1 chunk +0 lines, -31 lines 0 comments Download
D mojo/logging/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download
D mojo/logging/init_logging.h View 1 chunk +0 lines, -15 lines 0 comments Download
D mojo/logging/init_logging.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M mojo/mojo_base.gyp View 1 chunk +0 lines, -13 lines 0 comments Download
D mojo/test/BUILD.gn View 1 chunk +0 lines, -15 lines 0 comments Download
D mojo/test/test_utils.h View 1 chunk +0 lines, -21 lines 0 comments Download
D mojo/test/test_utils_posix.cc View 1 chunk +0 lines, -21 lines 0 comments Download
D mojo/test/test_utils_win.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D mojo/util/BUILD.gn View 1 chunk +0 lines, -15 lines 0 comments Download
D mojo/util/capture_util.h View 1 chunk +0 lines, -38 lines 0 comments Download
D mojo/util/filename_util.h View 1 chunk +0 lines, -31 lines 0 comments Download
D mojo/util/filename_util.cc View 1 chunk +0 lines, -88 lines 0 comments Download
M services/shell/public/cpp/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M services/shell/standalone/context.cc View 1 chunk +0 lines, -1 line 0 comments Download
M services/shell/tests/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 33 (18 generated)
Ben Goodger (Google)
4 years, 7 months ago (2016-05-25 18:17:10 UTC) #1
Ken Rockot(use gerrit already)
there's at least one dangling gyp target reference in content, but lgtm once it builds
4 years, 7 months ago (2016-05-25 18:24:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008383002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008383002/40001
4 years, 7 months ago (2016-05-25 18:28:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/71853)
4 years, 7 months ago (2016-05-25 18:40:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008383002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008383002/60001
4 years, 7 months ago (2016-05-25 19:10:37 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/100216)
4 years, 7 months ago (2016-05-25 19:47:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008383002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008383002/80001
4 years, 7 months ago (2016-05-25 19:56:47 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/193557)
4 years, 7 months ago (2016-05-25 20:21:48 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008383002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008383002/100001
4 years, 7 months ago (2016-05-25 20:27:15 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/117280) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-05-25 20:41:50 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008383002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008383002/120001
4 years, 7 months ago (2016-05-25 20:57:17 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/180361)
4 years, 7 months ago (2016-05-25 21:29:28 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008383002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008383002/140001
4 years, 7 months ago (2016-05-25 23:24:22 UTC) #30
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 7 months ago (2016-05-26 01:26:06 UTC) #31
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 01:27:02 UTC) #33
Message was sent while issue was closed. 
Patchset 8 (id:??) landed as
https://crrev.com/ba768a8531c059ae32a71b4cb18163f174110688
Cr-Commit-Position: refs/heads/master@{#396079}

Powered by Google App Engine
This is Rietveld 408576698