Issue 2008373002: Make sort method generic. This eliminates a large number of dynamic calls that slow down sorting un…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2008373002: Make sort method generic. This eliminates a large number of dynamic calls that slow down sorting un… (Closed)

Created:
4 years, 7 months ago by Jacob

Modified:
4 years, 7 months ago

Reviewers:
Leaf

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Make sort method generic. This eliminates a large number of dynamic calls that slow down sorting under ddc. BUG= R=leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/6cb121f84718b67ad9b75c9a395fe05de409963f

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	sdk/lib/internal/sort.dart	View		5 chunks	+6 lines, -6 lines	0 comments	Download

Total messages: 5 (2 generated)

Jacob

This is identical to the cl that just landed in the dev compiler repo.

4 years, 7 months ago (2016-05-25 18:10:06 UTC) #2

Jacob

4 years, 7 months ago (2016-05-25 19:33:46 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6cb121f84718b67ad9b75c9a395fe05de409963f (presubmit successful).