Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2008353002: Add ElementImpl.typeParameterContext getter. (Closed)

Created:
4 years, 7 months ago by scheglov
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add ElementImpl.typeParameterContext getter. When we need to resynthesize types of variables and parameters, we need to know the type parameter context. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/3b865560a95ed26fc98fd31f00c665c28c2623ac

Patch Set 1 #

Total comments: 5

Patch Set 2 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -34 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 1 9 chunks +26 lines, -12 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 6 chunks +6 lines, -22 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
4 years, 7 months ago (2016-05-25 17:09:53 UTC) #1
Paul Berry
lgtm https://codereview.chromium.org/2008353002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart File pkg/analyzer/lib/src/dart/element/element.dart (left): https://codereview.chromium.org/2008353002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart#oldcode1273 pkg/analyzer/lib/src/dart/element/element.dart:1273: Nit: keep this blank line. https://codereview.chromium.org/2008353002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart File pkg/analyzer/lib/src/dart/element/element.dart ...
4 years, 7 months ago (2016-05-25 17:16:52 UTC) #2
Brian Wilkerson
lgtm https://codereview.chromium.org/2008353002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart File pkg/analyzer/lib/src/dart/element/element.dart (right): https://codereview.chromium.org/2008353002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart#newcode1277 pkg/analyzer/lib/src/dart/element/element.dart:1277: @override Strange to have the blank line go ...
4 years, 7 months ago (2016-05-25 17:18:47 UTC) #3
scheglov
https://codereview.chromium.org/2008353002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart File pkg/analyzer/lib/src/dart/element/element.dart (right): https://codereview.chromium.org/2008353002/diff/1/pkg/analyzer/lib/src/dart/element/element.dart#newcode1277 pkg/analyzer/lib/src/dart/element/element.dart:1277: @override On 2016/05/25 17:18:47, Brian Wilkerson wrote: > Strange ...
4 years, 7 months ago (2016-05-25 17:26:59 UTC) #4
scheglov
4 years, 7 months ago (2016-05-25 17:30:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3b865560a95ed26fc98fd31f00c665c28c2623ac (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698