Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 2008343002: Move ScrollBehavior to ScrollTypes.h, so that ComputedStyle.h doesn't need to include ScrollableAre… (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, blink-reviews-style_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ScrollBehavior to ScrollTypes.h, so that ComputedStyle.h doesn't need to include ScrollableArea.h. BUG=614015 Committed: https://crrev.com/40726da4c8893792c5602ed9e351dd8575b1ba20 Cr-Commit-Position: refs/heads/master@{#395994}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutScrollbarPart.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollTypes.h View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableArea.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
@eae, you like?
4 years, 7 months ago (2016-05-25 16:03:38 UTC) #2
eae
Seems entirely reasonable to me. LGTM
4 years, 7 months ago (2016-05-25 16:58:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008343002/1
4 years, 7 months ago (2016-05-25 16:58:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 21:37:52 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 21:39:10 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/40726da4c8893792c5602ed9e351dd8575b1ba20
Cr-Commit-Position: refs/heads/master@{#395994}

Powered by Google App Engine
This is Rietveld 408576698