Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 20083002: Remove references to the v8-i18n extension in blink. (Closed)

Created:
7 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 5 months ago
Reviewers:
adamk, marja
CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, haraken, Nate Chapin, do-not-use
Visibility:
Public.

Description

Remove references to the v8-i18n extension in blink. It's not used anymore, we now use the V8 builtin i18n implementation. BUG=v8:2475 R=marja@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154834

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -37 lines) Patch
M Source/bindings/bindings.gyp View 2 chunks +0 lines, -12 lines 0 comments Download
M Source/bindings/v8/V8WindowShell.cpp View 2 chunks +0 lines, -9 lines 0 comments Download
M Source/core/core.gyp View 3 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jochen (gone - plz use gerrit)
7 years, 5 months ago (2013-07-24 09:46:44 UTC) #1
marja
lgtm
7 years, 5 months ago (2013-07-24 09:48:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/20083002/1
7 years, 5 months ago (2013-07-24 12:35:34 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=18222
7 years, 5 months ago (2013-07-24 13:31:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/20083002/1
7 years, 5 months ago (2013-07-24 13:43:27 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=18238
7 years, 5 months ago (2013-07-24 14:32:05 UTC) #6
jochen (gone - plz use gerrit)
Committed patchset #1 manually as r154834 (presubmit successful).
7 years, 5 months ago (2013-07-24 15:03:43 UTC) #7
adamk
7 years, 5 months ago (2013-07-24 18:33:40 UTC) #8
Message was sent while issue was closed.
Note that this was rolled out (before the rollout of the Chromium side) in
https://src.chromium.org/viewvc/blink?revision=154840&view=revision due to
LayoutTest failures.

Powered by Google App Engine
This is Rietveld 408576698