Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2008293002: Revert of [json] support replacer function in BasicJsonStringifier. (Closed)

Created:
4 years, 7 months ago by Yang
Modified:
4 years, 7 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@jsonproplist
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [json] support replacer function in BasicJsonStringifier. (patchset #4 id:60001 of https://codereview.chromium.org/2010533002/ ) Reason for revert: Layout test failure: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/7029 Original issue's description: > [json] support replacer function in BasicJsonStringifier. > > R=cbruni@chromium.org > > Committed: https://crrev.com/53d4594b849bed40d96389f00b6ce0ca1fff05bb > Cr-Commit-Position: refs/heads/master@{#36499} TBR=cbruni@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/7012babb9db0fa1b0aa8f859229ec0cc10122af9 Cr-Commit-Position: refs/heads/master@{#36512}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -154 lines) Patch
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/builtins.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/builtins.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M src/js/array.js View 1 chunk +4 lines, -0 lines 0 comments Download
M src/js/json.js View 3 chunks +151 lines, -0 lines 0 comments Download
M src/json-stringifier.h View 4 chunks +6 lines, -8 lines 0 comments Download
M src/json-stringifier.cc View 19 chunks +137 lines, -130 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/runtime-json.cc View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Yang
Created Revert of [json] support replacer function in BasicJsonStringifier.
4 years, 7 months ago (2016-05-25 11:35:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008293002/1
4 years, 7 months ago (2016-05-25 11:35:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 11:35:57 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 11:36:56 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7012babb9db0fa1b0aa8f859229ec0cc10122af9
Cr-Commit-Position: refs/heads/master@{#36512}

Powered by Google App Engine
This is Rietveld 408576698