Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5637)

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js

Issue 2008273003: Saved addresses and credit cards can be removed from md-settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js b/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
index ab491edefbf06b5ee2b90b71a2851a2f7642e988..845d87f7ed077b7ad25fffd257d2ec5743854423 100644
--- a/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
+++ b/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
@@ -94,8 +94,9 @@
* @private
*/
onMenuRemoveAddressTap_: function() {
- // TODO(hcarmona): implement removing an address.
- this.$.addressSharedMenu.closeMenu();
+ var menu = this.$.addressSharedMenu;
+ this.fire('remove-address', menu.itemData);
+ menu.closeMenu();
},
/**
@@ -139,8 +140,9 @@
* @private
*/
onMenuRemoveCreditCardTap_: function() {
- // TODO(hcarmona): implement removing a credit card.
- this.$.creditCardSharedMenu.closeMenu();
+ var menu = this.$.creditCardSharedMenu;
+ this.fire('remove-credit-card', menu.itemData);
+ menu.closeMenu();
},
/**
« no previous file with comments | « no previous file | chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698