courgette/encode_decode_unittest.cc - Issue 2008253004: Refactor rel32 searching process for x64 to make it more similar to x86.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: courgette/encode_decode_unittest.cc

Issue 2008253004: Refactor rel32 searching process for x64 to make it more similar to x86. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: courgette/encode_decode_unittest.cc

diff --git a/courgette/encode_decode_unittest.cc b/courgette/encode_decode_unittest.cc

index 6c52e20e7a1bb0979a3bd6acff4328818b81abd1..81bfd4a64afe8911ce80b3d1a97a1889099b2524 100644

--- a/courgette/encode_decode_unittest.cc

+++ b/courgette/encode_decode_unittest.cc

@@ -83,7 +83,7 @@ TEST_F(EncodeDecodeTest, PE) {

TEST_F(EncodeDecodeTest, PE64) {

std::string file = FileContents("chrome64_1.exe");

- TestAssembleToStreamDisassemble(file, 809635);

+ TestAssembleToStreamDisassemble(file, 809776);

huangs 2016/05/26 18:34:34 So algorithm changed? Please separate pure refact

etiennep 2016/05/26 20:50:09 Done.

}

TEST_F(EncodeDecodeTest, Elf_Small) {

« courgette/assembly_program.cc ('K') | « courgette/disassembler_win32_x86.cc ('k') | courgette/rel32_finder.h » ('j') | courgette/rel32_finder.cc » ('J')