courgette/testdata/rel32_x86_04.txt - Issue 2008253004: Refactor rel32 searching process for x64 to make it more similar to x86.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: courgette/testdata/rel32_x86_04.txt

Issue 2008253004: Refactor rel32 searching process for x64 to make it more similar to x86. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Improve rel32_finder doc Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Test false detection cases.	1 # Test false detection cases.

2	2

3 # .text start RVA and end RVA	3 # .text start RVA and end RVA

4 1000	4 1000

5 3000	5 3000

6 # .reloc start RVA and end RVA	6 # .reloc start RVA and end RVA

7 3800	7 3800

8 4000	8 4000

9 # End RVA	9 # End RVA

10 5000	10 5000

(...skipping 27 matching lines...) Expand all Loading...
38 Abs32:	38 Abs32:

39	39

40 Expected:	40 Expected:

41 1005 # False positive	41 1005 # False positive

42 1011 # False positive	42 1011 # False positive

43 # 1012 => False negative: shadowed by 1011	43 # 1012 => False negative: shadowed by 1011

44 101B # False positive	44 101B # False positive

45 # 1023 => Potential false positive, but suppressed since target is outside .text	45 # 1023 => Potential false positive, but suppressed since target is outside .text

46 1027 # Emerges since it's not shadowed by 1023	46 1027 # Emerges since it's not shadowed by 1023

47 1030 # False positive: target of 102E was outside .text, so fall back to this	47 1030 # False positive: target of 102E was outside .text, so fall back to this

OLD	NEW

« courgette/testdata/rel32_x64_03.txt ('K') | « courgette/testdata/rel32_x86_03.txt ('k') | no next file » | no next file with comments »