courgette/testdata/rel32_win32_x86_04.txt - Issue 2008253004: Refactor rel32 searching process for x64 to make it more similar to x86.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: courgette/testdata/rel32_win32_x86_04.txt

Issue 2008253004: Refactor rel32 searching process for x64 to make it more similar to x86. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Correct far away ptr in rel32_x64_03.txt test case Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
	(Empty)
1 # Test false detection cases.

2

3 # .text start RVA and end RVA

4 1000

5 3000

6 # .reloc start RVA and end RVA

7 3800

8 4000

9 # End RVA

10 5000

11

12 # Assume ImageBase = 00400000. This does not affect the test.

13 Program:

14 00401000: 55 push ebp

15 00401001: 8B EC mov ebp,esp

16 00401003: B8 E8 00 00 00 mov eax,0E8h # E8 00 00 00 00

17 00401008: 00 C0 add al,al

18 0040100A: 90 nop

19 0040100B: 90 nop

20 0040100C: B9 00 00 00 E9 mov ecx,0E9000000h # E9 E8 00 00 00

21 00401011: E8 00 00 00 00 call 00401016

22 00401016: 90 nop

23 00401017: 90 nop

24 00401018: B1 0F mov cl,0Fh # 0F 80 C0 00 00 00

25 0040101A: 80 C0 00 add al,0

26 0040101D: 00 00 add byte ptr [eax],al

27 0040101F: 90 nop

28 00401020: 90 nop

29 00401021: B8 E8 00 00 00 mov eax,0E8h # E8 00 00 00 E8

30 00401026: E8 00 00 00 00 call 0040102B

31 0040102B: 90 nop

32 0040102C: 90 nop

33 0040102D: E8 00 E9 00 00 call 0040F932 # E9 00 00 00 00

34 00401032: 00 00 add byte ptr [eax],al

35 00401034: 5D pop ebp

36 00401035: C3 ret

37

38 Abs32:

39

40 Expected:

41 1005 # False positive

42 1011 # False positive

43 # 1012 => False negative: shadowed by 1011

44 101B # False positive

45 # 1023 => Potential false positive, but suppressed since target is outside .text

46 1027 # Emerges since it's not shadowed by 1023

47 1030 # False positive: target of 102E was outside .text, so fall back to this

OLD	NEW

« no previous file with comments | « courgette/testdata/rel32_win32_x86_03.txt ('k') | courgette/testdata/rel32_x64_01.txt » ('j') | no next file with comments »