courgette/testdata/rel32_win32_x86_03.txt - Issue 2008253004: Refactor rel32 searching process for x64 to make it more similar to x86.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: courgette/testdata/rel32_win32_x86_03.txt

Issue 2008253004: Refactor rel32 searching process for x64 to make it more similar to x86. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
	(Empty)
1 # Test target validity: only accept target RVA in [1000, 3000).

2

3 # .text start RVA and end RVA

4 1000

5 3000

6 # .reloc start RVA and end RVA

7 3800

8 4000

9 # End RVA

10 5000

11

12 # Assume ImageBase = 00400000. This does not affect the test.

13 Program:

14 00401000: 55 push ebp

15 00401001: 8B EC mov ebp,esp

16 00401003: E8 F8 EF FF FF call 00400000 # RVA start, outside .text

17 00401008: E8 F3 FF FF FF call 00401000

18 0040100D: E8 ED FF FF FF call 00400FFF # 1 byte before .text

19 00401012: 90 nop # Padding so E8 & E9 ...

20 00401013: 90 nop

21 00401014: E9 E7 FF FF FF jmp 00401000 # ... don't appear here.

22 00401019: E9 E1 FF FF FF jmp 00400FFF # 1 byte before .text

23 0040101E: E8 DC 1F 00 00 call 00402FFF

24 00401023: E8 D8 1F 00 00 call 00403000 # 1 byte after .text

25 00401028: 0F 87 D1 1F 00 00 ja 00402FFF

26 0040102E: 0F 88 CC 1F 00 00 js 00403000 # 1 byte after .text

27 00401034: E8 C6 3F 00 00 call 00404FFF # In image, outside .text

28 00401039: E8 C2 3F 00 00 call 00405000 # Outside image

29 0040103E: E8 BE 3F 00 00 call 00405001 # Outside image

30 00401043: E8 88 88 88 88 call 88C898D0 # Far away

31 00401048: 5D pop ebp

32 00401049: C3 ret

33

34 Abs32:

35

36 Expected:

37 1009

38 1015

39 101F

40 102A

OLD	NEW