components/autofill/core/browser/webdata/autofill_table.cc - Issue 2008253003: Explicitly set modification_date when loading server entries from db.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/webdata/autofill_table.cc

Issue 2008253003: Explicitly set modification_date when loading server entries from db. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace base::Time() with Time() Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/autofill/core/browser/webdata/autofill_table.cc

diff --git a/components/autofill/core/browser/webdata/autofill_table.cc b/components/autofill/core/browser/webdata/autofill_table.cc

index fc234ae4107e4224ad0d880ebb76685d5b64a786..a4463156f482171baf112e207b4a1e25f6ad6e2a 100644

--- a/components/autofill/core/browser/webdata/autofill_table.cc

+++ b/components/autofill/core/browser/webdata/autofill_table.cc

@@ -953,6 +953,7 @@ bool AutofillTable::GetServerProfiles(std::vector<AutofillProfile*>* profiles) {

AutofillProfile::SERVER_PROFILE, s.ColumnString(index++)));

profile->set_use_count(s.ColumnInt64(index++));

profile->set_use_date(Time::FromInternalValue(s.ColumnInt64(index++)));

+ profile->set_modification_date(Time());

Mathieu 2016/05/25 20:28:46 comment? It's easy to miss the subtlety here and b

Justin Donnelly 2016/05/25 20:36:50 Done.

base::string16 recipient_name = s.ColumnString16(index++);

profile->SetRawInfo(COMPANY_NAME, s.ColumnString16(index++));

@@ -1219,6 +1220,7 @@ bool AutofillTable::GetServerCreditCards(

: full_card_number);

card->set_use_count(s.ColumnInt64(index++));

card->set_use_date(Time::FromInternalValue(s.ColumnInt64(index++)));

+ card->set_modification_date(Time());

std::string card_type = s.ColumnString(index++);

if (record_type == CreditCard::MASKED_SERVER_CARD) {

« no previous file with comments | « no previous file | components/autofill/core/browser/webdata/autofill_table_unittest.cc » ('j') | no next file with comments »