Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2008253003: Explicitly set modification_date when loading server entries from db. (Closed)

Created:
4 years, 7 months ago by Justin Donnelly
Modified:
4 years, 6 months ago
Reviewers:
Mathieu
CC:
bondd+autofillwatch_chromium.org, browser-components-watch_chromium.org, chromium-reviews, estade+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, rouslan+autofill_chromium.org, sebsg, vabr+watchlistautofill_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Explicitly set modification_date when loading server entries from db. Fixes an issue where the modification_date on server cards and profiles is always set to base::Time::Now(). BUG=614803 Committed: https://crrev.com/914445df51cdeae9a867061c32e3b9bbe8784078 Cr-Commit-Position: refs/heads/master@{#396229}

Patch Set 1 #

Patch Set 2 : Replace base::Time() with Time() #

Total comments: 2

Patch Set 3 : Add comments to implementation file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M components/autofill/core/browser/webdata/autofill_table.cc View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M components/autofill/core/browser/webdata/autofill_table_unittest.cc View 8 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Justin Donnelly
4 years, 7 months ago (2016-05-25 20:24:25 UTC) #2
Mathieu
lgtm with nit https://codereview.chromium.org/2008253003/diff/20001/components/autofill/core/browser/webdata/autofill_table.cc File components/autofill/core/browser/webdata/autofill_table.cc (right): https://codereview.chromium.org/2008253003/diff/20001/components/autofill/core/browser/webdata/autofill_table.cc#newcode956 components/autofill/core/browser/webdata/autofill_table.cc:956: profile->set_modification_date(Time()); comment? It's easy to miss ...
4 years, 7 months ago (2016-05-25 20:28:46 UTC) #3
Justin Donnelly
https://codereview.chromium.org/2008253003/diff/20001/components/autofill/core/browser/webdata/autofill_table.cc File components/autofill/core/browser/webdata/autofill_table.cc (right): https://codereview.chromium.org/2008253003/diff/20001/components/autofill/core/browser/webdata/autofill_table.cc#newcode956 components/autofill/core/browser/webdata/autofill_table.cc:956: profile->set_modification_date(Time()); On 2016/05/25 20:28:46, Mathieu Perreault wrote: > comment? ...
4 years, 7 months ago (2016-05-25 20:36:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008253003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008253003/40001
4 years, 6 months ago (2016-05-26 18:07:38 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-05-26 18:12:23 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-05-26 18:13:45 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/914445df51cdeae9a867061c32e3b9bbe8784078
Cr-Commit-Position: refs/heads/master@{#396229}

Powered by Google App Engine
This is Rietveld 408576698