Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2008243002: [turbofan] The BytecodeGraphBuilder should never insert the empty frame state. (Closed)

Created:
4 years, 7 months ago by Benedikt Meurer
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] The BytecodeGraphBuilder should never insert the empty frame state. It's always possible to deoptimize to Ignition from TurboFan, and we don't use Ignition for asm.js code, so there's no need to have the empty frame state magic in the BytecodeGraphBuilder. R=mstarzinger@chromium.org BUG=v8:4280 Committed: https://crrev.com/a329afdaecceca133b1bcaefc566bcfe0636b2d1 Cr-Commit-Position: refs/heads/master@{#36505}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M src/compiler/bytecode-graph-builder.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 4 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Benedikt Meurer
4 years, 7 months ago (2016-05-25 09:09:02 UTC) #1
Jarin
lgtm
4 years, 7 months ago (2016-05-25 09:22:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008243002/1
4 years, 7 months ago (2016-05-25 09:23:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 09:41:49 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a329afdaecceca133b1bcaefc566bcfe0636b2d1 Cr-Commit-Position: refs/heads/master@{#36505}
4 years, 7 months ago (2016-05-25 09:44:08 UTC) #8
Michael Starzinger
4 years, 7 months ago (2016-05-25 10:48:15 UTC) #9
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698