Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: chrome/browser/page_load_metrics/observers/reload_page_load_metrics_observer.cc

Issue 2008233002: Add ReloadPageLoadMetricsObserver to have a metrics variant for reloads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review #7, #8 Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/reload_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/reload_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/reload_page_load_metrics_observer.cc
new file mode 100644
index 0000000000000000000000000000000000000000..1ddecc3408d9ea28fac060b536d63259a4624985
--- /dev/null
+++ b/chrome/browser/page_load_metrics/observers/reload_page_load_metrics_observer.cc
@@ -0,0 +1,50 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/page_load_metrics/observers/reload_page_load_metrics_observer.h"
+
+#include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h"
+#include "components/page_load_metrics/browser/page_load_metrics_util.h"
+#include "ui/base/page_transition_types.h"
+
+namespace chrome {
+
+namespace {
+
+const char kHistogramFirstContentfulPaintReload[] =
+ "PageLoad.Clients.Reload.PaintTiming.NavigationToFirstContentfulPaint";
+const char kHistogramFirstContentfulPaintReloadByGesture[] =
+ "PageLoad.Clients.Reload.PaintTiming.NavigationToFirstContentfulPaint."
+ "UserGesture";
+
+} // namespace
+
+ReloadPageLoadMetricsObserver::ReloadPageLoadMetricsObserver()
+ : page_transition_was_reload_(false), initiated_by_user_gesture_(false) {}
+
+void ReloadPageLoadMetricsObserver::OnCommit(
+ content::NavigationHandle* navigation_handle) {
+ page_transition_was_reload_ = ui::PageTransitionCoreTypeIs(
+ navigation_handle->GetPageTransition(), ui::PAGE_TRANSITION_RELOAD);
+ initiated_by_user_gesture_ = navigation_handle->HasUserGesture();
+}
+
+void ReloadPageLoadMetricsObserver::OnFirstContentfulPaint(
+ const page_load_metrics::PageLoadTiming& timing,
+ const page_load_metrics::PageLoadExtraInfo& extra_info) {
+ if (!page_transition_was_reload_ ||
+ !WasStartedInForegroundEventInForeground(timing.first_contentful_paint,
+ extra_info)) {
+ return;
+ }
+
+ PAGE_LOAD_HISTOGRAM(kHistogramFirstContentfulPaintReload,
+ timing.first_contentful_paint);
+ if (initiated_by_user_gesture_) {
+ PAGE_LOAD_HISTOGRAM(kHistogramFirstContentfulPaintReloadByGesture,
+ timing.first_contentful_paint);
+ }
+}
+
+} // namespace chrome

Powered by Google App Engine
This is Rietveld 408576698