tools/metrics/histograms/histograms.xml - Issue 2008233002: Add ReloadPageLoadMetricsObserver to have a metrics variant for reloads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2008233002: Add ReloadPageLoadMetricsObserver to have a metrics variant for reloads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 15bd59778cc5f97fb8cc636c7e6d730001186c66..a2e45fc09ffb3430e38afefc0eaca2ad738b83ac 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -94926,6 +94926,14 @@ To add a new entry, add it with any value and run test to compute valid value.

<affected-histogram name="PageLoad.Timing2.ParseStartToFirstContentfulPaint"/>

</histogram_suffixes>

+<histogram_suffixes name="PageLoadMetricsClients.Reload" separator="."

Takashi Toyoshima 2016/05/26 06:06:50 I created a separate histogram_suffixes tag to avo

+ ordering="prefix">

+ <suffix name="Clients.Reload"

+ label="PageLoadMetrics from a page that is reloaded"/>

+ <affected-histogram

+ name="PageLoad.PaintTiming.NavigationToFirstContentfulPaint"/>

Takashi Toyoshima 2016/05/26 06:06:50 I also should have -.ByGesture here. But I could n

Bryan McQuade 2016/05/26 10:43:34 You can create a second suffix for it, with affect

Takashi Toyoshima 2016/05/27 03:09:48 Thanks. Let me try it.

+</histogram_suffixes>

<histogram_suffixes name="PageLoadType">

<suffix name="HistoryLoad"

label="but only for user pressing back or forward"/>

« chrome/browser/page_load_metrics/observers/reload_page_load_metrics_observer.cc ('K') | « chrome/chrome_browser.gypi ('k') | no next file » | no next file with comments »