Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 20082002: Extend existing blink test expectations for slow tests. (Closed)

Created:
7 years, 5 months ago by Michael Achenbach
Modified:
7 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Extend existing blink test expectations for slow tests. The test plugins/js-from-destroy.html has crash and timeout expectations for some configurations but not on windows release. Add 'slow', since there is a timeout only on the v8 waterfall and only for windows release. BUG=webkit.org/b/48655 R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15852

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/blink_tests/TestExpectations View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL
7 years, 5 months ago (2013-07-24 09:19:37 UTC) #1
Michael Starzinger
LGTM (rubber-stamped).
7 years, 5 months ago (2013-07-24 09:27:41 UTC) #2
Michael Achenbach
7 years, 5 months ago (2013-07-24 09:46:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15852 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698