services/navigation/view_impl.cc - Issue 2008193002: Change mojo geometry structs from using type converters to StructTraits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/navigation/view_impl.cc

Issue 2008193002: Change mojo geometry structs from using type converters to StructTraits. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « services/navigation/public/interfaces/BUILD.gn ('k') | ui/display/mojo/display_type_converters.cc » ('j') | ui/gfx/geometry/mojo/geometry_struct_traits.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/navigation/view_impl.cc

diff --git a/services/navigation/view_impl.cc b/services/navigation/view_impl.cc

index 23c9bd5d89165c00ad376a6ee2ef225b373dbcb7..9728d97baf5e04318b08ff0da635fa9ef7ed2e31 100644

--- a/services/navigation/view_impl.cc

+++ b/services/navigation/view_impl.cc

@@ -8,7 +8,6 @@

#include "components/mus/public/cpp/window_tree_connection.h"

#include "content/public/browser/navigation_controller.h"

#include "content/public/browser/web_contents.h"

-#include "ui/gfx/geometry/mojo/geometry_type_converters.h"

#include "ui/views/controls/webview/webview.h"

#include "ui/views/mus/native_widget_mus.h"

#include "ui/views/widget/widget.h"

@@ -71,8 +70,7 @@ void ViewImpl::AddNewContents(content::WebContents* source,

mojom::ViewPtr view;

mojom::ViewRequest view_request = GetProxy(&view);

client_->ViewCreated(std::move(view), GetProxy(&client),

- disposition == NEW_POPUP, mojo::Rect::From(initial_rect),

- user_gesture);

+ disposition == NEW_POPUP, initial_rect, user_gesture);

ViewImpl* impl =

new ViewImpl(connector_, new_contents->GetBrowserContext(),

std::move(client), std::move(view_request), ref_->Clone());