Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1151)

Unified Diff: media/mojo/services/media_mojo_unittest.cc

Issue 2008193002: Change mojo geometry structs from using type converters to StructTraits. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/mojo/services/media_mojo_unittest.cc
diff --git a/media/mojo/services/media_mojo_unittest.cc b/media/mojo/services/media_mojo_unittest.cc
index 2c1955a21d4203d0d44d50c7ae1fee7da11ad501..8f4d52067e18a287bfd0d4fdc3a58ce06fe05fe2 100644
--- a/media/mojo/services/media_mojo_unittest.cc
+++ b/media/mojo/services/media_mojo_unittest.cc
@@ -48,13 +48,7 @@ class MockRendererClient : public mojom::RendererClient {
MOCK_METHOD0(OnEnded, void());
MOCK_METHOD0(OnError, void());
MOCK_METHOD1(OnVideoOpacityChange, void(bool opaque));
-
- // TODO(alokp): gmock does not support move-only function arguments.
- // Convert this into MOCK_METHOD after gmock implements this feature.
- // https://github.com/google/googletest/issues/395
- // If we need to use this mock method before the gmock bug gets fixed, we
- // would need to define a MOCK_METHOD using non movable type which calls this.
- void OnVideoNaturalSizeChange(mojo::SizePtr size) override {}
+ MOCK_METHOD1(OnVideoNaturalSizeChange, void(const gfx::Size& size));
private:
DISALLOW_COPY_AND_ASSIGN(MockRendererClient);

Powered by Google App Engine
This is Rietveld 408576698