mash/browser/browser.cc - Issue 2008193002: Change mojo geometry structs from using type converters to StructTraits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mash/browser/browser.cc

Issue 2008193002: Change mojo geometry structs from using type converters to StructTraits. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/mus/render_widget_mus_connection.cc ('k') | mash/example/window_type_launcher/window_type_launcher.cc » ('j') | ui/gfx/geometry/mojo/geometry_struct_traits.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mash/browser/browser.cc

diff --git a/mash/browser/browser.cc b/mash/browser/browser.cc

index 431569dfe372a032519026a34920a34468a1ae99..eab9a9d5620008ccd9fca075917200844259fc8b 100644

--- a/mash/browser/browser.cc

+++ b/mash/browser/browser.cc

@@ -22,7 +22,6 @@

#include "services/tracing/public/cpp/tracing_impl.h"

#include "ui/aura/mus/mus_util.h"

#include "ui/gfx/canvas.h"

-#include "ui/gfx/geometry/mojo/geometry_type_converters.h"

#include "ui/gfx/paint_throbber.h"

#include "ui/gfx/text_constants.h"

#include "ui/native_theme/native_theme.h"

@@ -280,12 +279,12 @@ class UI : public views::WidgetDelegateView,

void ViewCreated(navigation::mojom::ViewPtr view,

navigation::mojom::ViewClientRequest request,

bool is_popup,

- mojo::RectPtr initial_rect,

+ const gfx::Rect& initial_rect,

bool user_gesture) override {

views::Widget* window = views::Widget::CreateWindowWithContextAndBounds(

new UI(browser_, is_popup ? UI::Type::POPUP : UI::Type::WINDOW,

std::move(view), std::move(request)),

- nullptr, initial_rect.To<gfx::Rect>());

+ nullptr, initial_rect);

window->Show();

browser_->AddWindow(window);

}