Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2008183004: Remove Earl Grey matcher APIs taking NSString. (Closed)

Created:
4 years, 7 months ago by baxley
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Earl Grey matcher APIs taking NSString. std::string APIs provide cleaner code in tests, which have been adopted by all tests. BUG=614167 Committed: https://crrev.com/380c6cda0109db823121542b2c93783803f5aa33 Cr-Commit-Position: refs/heads/master@{#396014}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -28 lines) Patch
M ios/web/public/test/earl_grey/web_view_matchers.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/web/public/test/earl_grey/web_view_matchers.mm View 1 chunk +0 lines, -6 lines 0 comments Download
M ios/web/shell/test/earl_grey/shell_matchers.h View 1 chunk +0 lines, -8 lines 0 comments Download
M ios/web/shell/test/earl_grey/shell_matchers.mm View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
baxley
Removing the NSString version of the matchers before any other tests start to use them.
4 years, 7 months ago (2016-05-25 21:09:09 UTC) #2
Eugene But (OOO till 7-30)
lgtm
4 years, 7 months ago (2016-05-25 21:11:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008183004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008183004/1
4 years, 7 months ago (2016-05-25 21:12:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 22:42:51 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 22:43:57 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/380c6cda0109db823121542b2c93783803f5aa33
Cr-Commit-Position: refs/heads/master@{#396014}

Powered by Google App Engine
This is Rietveld 408576698