Issue 2008163002: Add types on internal DateTime accessors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2008163002: Add types on internal DateTime accessors (Closed)

Created:
4 years, 7 months ago by Alan Knight

Modified:
4 years, 7 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -11 lines)			Patch
	M	sdk/lib/_internal/js_runtime/lib/js_helper.dart	View	1	4 chunks	+11 lines, -11 lines	0 comments	Download

Total messages: 5 (2 generated)

Alan Knight

See https://codereview.chromium.org/2004463004/ and https://codereview.chromium.org/2010693002/ in dev_compiler

4 years, 7 months ago (2016-05-25 00:24:56 UTC) #2

Alan Knight

4 years, 7 months ago (2016-05-25 00:36:38 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
088dd409fc8acb568e97bc89800e3f98ffbefbb7 (presubmit successful).