Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2008153003: [DevTools] Change name type in NativeBreakpoint to raw string (Closed)

Created:
4 years, 7 months ago by kozy
Modified:
4 years, 7 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Change name type in NativeBreakpoint to raw string All callers pass raw pointer as argument. We can avoid String allocation for each call when inspector is closed. BUG=614457 R=dgozman@chromium.org Committed: https://crrev.com/87a0cc1f353d4607abd5e7c948c2d05f2243a4a8 Cr-Commit-Position: refs/heads/master@{#395983}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
kozy
Dmitry, please take a look
4 years, 7 months ago (2016-05-25 16:32:25 UTC) #1
dgozman
lgtm
4 years, 7 months ago (2016-05-25 16:46:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008153003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008153003/1
4 years, 7 months ago (2016-05-25 16:46:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 20:39:27 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 20:42:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/87a0cc1f353d4607abd5e7c948c2d05f2243a4a8
Cr-Commit-Position: refs/heads/master@{#395983}

Powered by Google App Engine
This is Rietveld 408576698