Chromium Code Reviews

Issue 2008133002: Fix cross-partition dependency handling (issue 26466) (Closed)

Created:
4 years, 7 months ago by Brian Wilkerson
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Stats (+117 lines, -40 lines)
M pkg/analyzer/lib/src/context/cache.dart View 10 chunks +71 lines, -27 lines 0 comments
M pkg/analyzer/lib/src/context/context.dart View 4 chunks +26 lines, -10 lines 2 comments
M pkg/analyzer/lib/src/generated/engine.dart View 1 chunk +6 lines, -0 lines 0 comments
M pkg/analyzer/lib/src/task/dart_work_manager.dart View 1 chunk +1 line, -1 line 0 comments
M pkg/analyzer/test/generated/engine_test.dart View 1 chunk +6 lines, -2 lines 0 comments
M pkg/analyzer/test/src/task/dart_work_manager_test.dart View 1 chunk +7 lines, -0 lines 0 comments

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
4 years, 7 months ago (2016-05-24 21:55:04 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2008133002/diff/1/pkg/analyzer/lib/src/context/context.dart File pkg/analyzer/lib/src/context/context.dart (right): https://codereview.chromium.org/2008133002/diff/1/pkg/analyzer/lib/src/context/context.dart#newcode704 pkg/analyzer/lib/src/context/context.dart:704: onResultInvalidatedSubscription.cancel(); We could use here: onResultInvalidatedSubscription?.cancel();
4 years, 7 months ago (2016-05-25 01:44:44 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2008133002/diff/1/pkg/analyzer/lib/src/context/context.dart File pkg/analyzer/lib/src/context/context.dart (right): https://codereview.chromium.org/2008133002/diff/1/pkg/analyzer/lib/src/context/context.dart#newcode704 pkg/analyzer/lib/src/context/context.dart:704: onResultInvalidatedSubscription.cancel(); Done
4 years, 7 months ago (2016-05-25 14:42:34 UTC) #4
Brian Wilkerson
4 years, 7 months ago (2016-05-25 14:43:04 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
7eddfb739418f2f67044cb3864894f2cd2cbd581 (presubmit successful).

Powered by Google App Engine