Notify the BluetoothAdapter::Observer when a bluetooth peripheral disconnects

Notify the BluetoothAdapter::Observer when a bluetooth peripheral disconnects
on Android and Mac.

BUG=582537
TEST=The "Connecting and disconnecting" section of https://goo.gl/XwzFlR#heading=h.efzd105luqv2.

Committed: https://crrev.com/e7ee2ca3a44637a7dbc964978a74f5cd07865c02
Cr-Commit-Position: refs/heads/master@{#395815}

[Jeffrey Yasskin, 2016-05-24 21:27:12]

The CQ bit was checked by jyasskin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-24 21:27:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2008113002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2008113002/1

[Jeffrey Yasskin, 2016-05-24 22:04:04]

Description was changed from

==========
Notify the BluetoothAdapter::Observer when a bluetooth peripheral disconnects
on Android and Mac.

BUG=582537
==========

to

==========
Notify the BluetoothAdapter::Observer when a bluetooth peripheral disconnects
on Android and Mac.

BUG=582537
TEST=The "Connecting and disconnecting" section of
https://goo.gl/XwzFlR#heading=h.efzd105luqv2.
==========

[Jeffrey Yasskin, 2016-05-24 22:04:05]

jyasskin@chromium.org changed reviewers:
+ scheib@chromium.org

[commit-bot: I haz the power, 2016-05-24 22:16:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-24 22:16:14]

Dry run: Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Jeffrey Yasskin, 2016-05-24 23:23:54]

The CQ bit was checked by jyasskin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-24 23:24:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2008113002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2008113002/20001

[scheib, 2016-05-24 23:34:35]

https://codereview.chromium.org/2008113002/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_adapter.h (right):

https://codereview.chromium.org/2008113002/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_adapter.h:88: virtual void
DeviceChanged(BluetoothAdapter* adapter,
Please add disconnection to the comment; I'd like to improve the specification
clarity of these methods.

https://codereview.chromium.org/2008113002/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_device_unittest.cc (right):

https://codereview.chromium.org/2008113002/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_device_unittest.cc:475: EXPECT_EQ(1,
observer.device_changed_count());
These additions are fine, but I sought a simpler test where they may be cleaner.
I didn't find one. I think a test specifically for measuring
device_changed_count at the right times is reasonable, instead of growing these
tests.

[commit-bot: I haz the power, 2016-05-25 00:06:56]

Dry run: None

[Jeffrey Yasskin, 2016-05-25 00:07:44]

The CQ bit was checked by jyasskin@chromium.org to run a CQ dry run

[Jeffrey Yasskin, 2016-05-25 00:08:13]

https://codereview.chromium.org/2008113002/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_adapter.h (right):

https://codereview.chromium.org/2008113002/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_adapter.h:88: virtual void
DeviceChanged(BluetoothAdapter* adapter,
On 2016/05/24 23:34:34, scheib wrote:
> Please add disconnection to the comment; I'd like to improve the specification
> clarity of these methods.

I've listed the methods whose changes this event reports. I'm not sure it makes
sense to specifically list "disconnection" since the method is really about
changing properties.

https://codereview.chromium.org/2008113002/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_device_unittest.cc (right):

https://codereview.chromium.org/2008113002/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_device_unittest.cc:475: EXPECT_EQ(1,
observer.device_changed_count());
On 2016/05/24 23:34:34, scheib wrote:
> These additions are fine, but I sought a simpler test where they may be
cleaner.
> I didn't find one. I think a test specifically for measuring
> device_changed_count at the right times is reasonable, instead of growing
these
> tests.

Done.

https://codereview.chromium.org/2008113002/diff/40001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_device.cc (right):

https://codereview.chromium.org/2008113002/diff/40001/device/bluetooth/blueto...
device/bluetooth/bluetooth_device.cc:29: for (BluetoothGattConnection*
connection : gatt_connections_) {
Also note this change to ~BluetoothDevice to avoid calls to pure virtual
functions from observers.

[commit-bot: I haz the power, 2016-05-25 00:08:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2008113002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2008113002/40001

[scheib, 2016-05-25 01:06:55]

LGTM

https://codereview.chromium.org/2008113002/diff/40001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_device.cc (right):

https://codereview.chromium.org/2008113002/diff/40001/device/bluetooth/blueto...
device/bluetooth/bluetooth_device.cc:29: for (BluetoothGattConnection*
connection : gatt_connections_) {
On 2016/05/25 00:08:13, Jeffrey Yasskin wrote:
> Also note this change to ~BluetoothDevice to avoid calls to pure virtual
> functions from observers.

Acknowledged.

[commit-bot: I haz the power, 2016-05-25 03:57:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-25 03:57:04]

Dry run: This issue passed the CQ dry run.

[commit-bot: I haz the power, 2016-05-25 03:57:13]

Dry run: None

[Jeffrey Yasskin, 2016-05-25 06:35:03]

The CQ bit was checked by jyasskin@chromium.org

[commit-bot: I haz the power, 2016-05-25 06:35:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2008113002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2008113002/40001

[commit-bot: I haz the power, 2016-05-25 06:38:40]

Description was changed from

==========
Notify the BluetoothAdapter::Observer when a bluetooth peripheral disconnects
on Android and Mac.

BUG=582537
TEST=The "Connecting and disconnecting" section of
https://goo.gl/XwzFlR#heading=h.efzd105luqv2.
==========

to

==========
Notify the BluetoothAdapter::Observer when a bluetooth peripheral disconnects
on Android and Mac.

BUG=582537
TEST=The "Connecting and disconnecting" section of
https://goo.gl/XwzFlR#heading=h.efzd105luqv2.
==========

[commit-bot: I haz the power, 2016-05-25 06:38:41]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-25 06:39:51]

Description was changed from

==========
Notify the BluetoothAdapter::Observer when a bluetooth peripheral disconnects
on Android and Mac.

BUG=582537
TEST=The "Connecting and disconnecting" section of
https://goo.gl/XwzFlR#heading=h.efzd105luqv2.
==========

to

==========
Notify the BluetoothAdapter::Observer when a bluetooth peripheral disconnects
on Android and Mac.

BUG=582537
TEST=The "Connecting and disconnecting" section of
https://goo.gl/XwzFlR#heading=h.efzd105luqv2.

Committed: https://crrev.com/e7ee2ca3a44637a7dbc964978a74f5cd07865c02
Cr-Commit-Position: refs/heads/master@{#395815}
==========

[commit-bot: I haz the power, 2016-05-25 06:39:52]

Patchset 3 (id:??) landed as
https://crrev.com/e7ee2ca3a44637a7dbc964978a74f5cd07865c02
Cr-Commit-Position: refs/heads/master@{#395815}