Remove experimental permission from infobars API and moving it to dev channel

Remove experimental permission from infobars API and moving it to dev channel

BUG=259493
TBR=hnguyen@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214692

[pals, 2013-07-24 09:18:24]

+pkasting for infobars
+mpcomplete for rest

Please review.

[Matt Perry, 2013-07-24 18:35:26]

Please add bug 39511 to the BUG= line.

https://codereview.chromium.org/20081002/diff/7001/chrome/browser/infobars/in...
File chrome/browser/infobars/infobar_extension_apitest.cc (right):

https://codereview.chromium.org/20081002/diff/7001/chrome/browser/infobars/in...
chrome/browser/infobars/infobar_extension_apitest.cc:18:
ASSERT_TRUE(RunExtensionTest("infobars")) << message_;
You need to update the extension associated with this test. See
chrome/test/data/extensions/api_test/infobars .

There's also a few other tests and samples in the codebase that use it. See
https://code.google.com/p/chromium/codesearch#search/&q=experimental.infobars...

https://codereview.chromium.org/20081002/diff/7001/chrome/common/extensions/a...
File chrome/common/extensions/api/_permission_features.json (right):

https://codereview.chromium.org/20081002/diff/7001/chrome/common/extensions/a...
chrome/common/extensions/api/_permission_features.json:293: "channel": "dev",
Make this "trunk" instead.. This API isn't ready for the dev channel.

[Peter Kasting, 2013-07-24 18:51:03]

Why do we actually want to ship this?  The implementation imposes some costs on
the infobar system, and every time I've asked in the past several years no one
has had a strong reason to want this feature.

I would much prefer that we kill this entirely.  Can you supply some rationale
supporting going the other direction?

[Matt Perry, 2013-07-24 18:55:54]

On 2013/07/24 18:51:03, Peter Kasting wrote:
> Why do we actually want to ship this?  The implementation imposes some costs
on
> the infobar system, and every time I've asked in the past several years no one
> has had a strong reason to want this feature.
> 
> I would much prefer that we kill this entirely.  Can you supply some rationale
> supporting going the other direction?

https://code.google.com/p/chromium/issues/detail?id=39511 has the actual
history. The short answer for why we *might* want to ship this is that if we
don't, extension developers will just implement toolbars using content scripts
to modify every page. That's bad from a security, usability, and performance
standpoint.

But note that we still haven't decided we want to ship it. The "experimental"
prefix is a deprecated way of implementing new APIs - instead, we prefer to
restrict them to a specific channel (trunk, in this case). So we're trying to
clean up all the old experimental APIs and move them to this new system.

IOW, this is a cleanup patch, not a "launch it" patch.

[Peter Kasting, 2013-07-24 18:56:52]

I see.  In that case LGTM for c/b/infobars.

[pals, 2013-07-25 06:15:26]

+kalman for doc server changes and extensions
Fixed presubmit checks and updated the doc server. I am not sure about the doc
server changes, did a mechanical renames. Please review.

[pals, 2013-07-25 06:17:24]

On 2013/07/25 06:15:26, sanjoyp wrote:
> +kalman for doc server changes and extensions
> Fixed presubmit checks and updated the doc server. I am not sure about the doc
> server changes, did a mechanical renames. Please review.

Also, i tried the patch using git cl try, but not able see the log where its
failing.

[not at google - send to devlin, 2013-07-25 14:21:15]

https://codereview.chromium.org/20081002/diff/26001/chrome/common/extensions/...
File chrome/common/extensions/docs/server2/app.yaml (right):

https://codereview.chromium.org/20081002/diff/26001/chrome/common/extensions/...
chrome/common/extensions/docs/server2/app.yaml:2: version: 2-13-1
if you're only changing a test you don't need to bump the app version

[pals, 2013-07-26 10:59:05]

Reverted the version change. Please review.

https://codereview.chromium.org/20081002/diff/26001/chrome/common/extensions/...
File chrome/common/extensions/docs/server2/app.yaml (right):

https://codereview.chromium.org/20081002/diff/26001/chrome/common/extensions/...
chrome/common/extensions/docs/server2/app.yaml:2: version: 2-13-1
On 2013/07/25 14:21:15, kalman wrote:
> if you're only changing a test you don't need to bump the app version

Done. Reverted the change.

[Matt Perry, 2013-07-26 18:26:23]

LGTM with below fixed.

https://codereview.chromium.org/20081002/diff/35001/AUTHORS
File AUTHORS (right):

https://codereview.chromium.org/20081002/diff/35001/AUTHORS#newcode220
AUTHORS:220: Sanjoy Pal <sanjoy.pal@samsung.com>
Are you the same Sanjoy Pal? Pick one email address :)

https://codereview.chromium.org/20081002/diff/35001/chrome/test/data/extensio...
File chrome/test/data/extensions/api_test/infobars/test.js (right):

https://codereview.chromium.org/20081002/diff/35001/chrome/test/data/extensio...
chrome/test/data/extensions/api_test/infobars/test.js:33: "tabId": tabA});
fix the indent here

https://codereview.chromium.org/20081002/diff/35001/chrome/test/data/extensio...
chrome/test/data/extensions/api_test/infobars/test.js:57: "tabId": tabB},
ditto

[pals, 2013-07-29 06:04:04]

fixed indentations.

https://codereview.chromium.org/20081002/diff/35001/AUTHORS
File AUTHORS (right):

https://codereview.chromium.org/20081002/diff/35001/AUTHORS#newcode220
AUTHORS:220: Sanjoy Pal <sanjoy.pal@samsung.com>
On 2013/07/26 18:26:24, Matt Perry wrote:
> Are you the same Sanjoy Pal? Pick one email address :)
I have previously contributed from motorola.com email. Now, I joined samsung. I
don't have access to motorola email anymore. Should I remove motorola email
because I see there are some duplicate emails for some people.

https://codereview.chromium.org/20081002/diff/35001/chrome/test/data/extensio...
File chrome/test/data/extensions/api_test/infobars/test.js (right):

https://codereview.chromium.org/20081002/diff/35001/chrome/test/data/extensio...
chrome/test/data/extensions/api_test/infobars/test.js:33: "tabId": tabA});
On 2013/07/26 18:26:24, Matt Perry wrote:
> fix the indent here

Done.

https://codereview.chromium.org/20081002/diff/35001/chrome/test/data/extensio...
chrome/test/data/extensions/api_test/infobars/test.js:57: "tabId": tabB},
On 2013/07/26 18:26:24, Matt Perry wrote:
> ditto

Done.

[commit-bot: I haz the power, 2013-07-29 06:04:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/20081002/42001

[commit-bot: I haz the power, 2013-07-29 06:04:44]

Failed to apply patch for AUTHORS:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file AUTHORS
  Hunk #1 FAILED at 217.
  1 out of 1 hunk FAILED -- saving rejects to file AUTHORS.rej

Patch:       AUTHORS
Index: AUTHORS
diff --git a/AUTHORS b/AUTHORS
index
8b07db1b94506e6dc524517d92cffe00f9f200bf..9990342f0b6969cdeafcd922dd840d0ab9e1fa1f
100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -217,6 +217,7 @@ Ryuan Choi <ryuan.choi@samsung.com>
 Sam Larison <qufighter@gmail.com>
 Sam McDonald <sam@sammcd.com>
 Sanjoy Pal <ncj674@motorola.com>
+Sanjoy Pal <sanjoy.pal@samsung.com>
 Sathish Kuppuswamy <sathish.kuppuswamy@intel.com>
 Satoshi Matsuzaki <satoshi.matsuzaki@gmail.com>
 Sean Bryant <sean@cyberwang.net>

[commit-bot: I haz the power, 2013-07-29 06:48:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/20081002/52001

[commit-bot: I haz the power, 2013-07-29 06:48:37]

Failed to apply patch for AUTHORS:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file AUTHORS
  Hunk #1 FAILED at 217.
  Hunk #2 FAILED at 251.
  2 out of 2 hunks FAILED -- saving rejects to file AUTHORS.rej

Patch:       AUTHORS
Index: AUTHORS
diff --git a/AUTHORS b/AUTHORS
index
8b07db1b94506e6dc524517d92cffe00f9f200bf..614d363f1532d806ff6b4fec7d84dccf736003dc
100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -217,6 +217,8 @@ Ryuan Choi <ryuan.choi@samsung.com>
 Sam Larison <qufighter@gmail.com>
 Sam McDonald <sam@sammcd.com>
 Sanjoy Pal <ncj674@motorola.com>
+Sanjoy Pal <sanjoy.pal@samsung.com>
+Sanne Wouda <sanne.wouda@gmail.com>
 Sathish Kuppuswamy <sathish.kuppuswamy@intel.com>
 Satoshi Matsuzaki <satoshi.matsuzaki@gmail.com>
 Sean Bryant <sean@cyberwang.net>
@@ -251,6 +253,7 @@ Umar Hansa <umar.hansa@gmail.com>
 Vamshikrishna Yellenki <vamshi@motorola.com>
 Vedran Šajatović <vedran.sajatovic@gmail.com>
 Vernon Tang <vt@foilhead.net>
+Viatcheslav Ostapenko <sl.ostapenko@samsung.com>
 Viet-Trung Luu <viettrungluu@gmail.com>
 Vinay Anantharaman <vinaya@adobe.com>
 Vipul Bhasin <vipul.bhasin@gmail.com>

[commit-bot: I haz the power, 2013-07-29 07:11:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/20081002/64001

[commit-bot: I haz the power, 2013-07-29 07:11:17]

Failed to apply patch for
chrome/browser/extensions/extension_function_histogram_value.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/extensions/extension_function_histogram_value.h
  Hunk #1 FAILED at 570.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/extensions/extension_function_histogram_value.h.rej

Patch:       chrome/browser/extensions/extension_function_histogram_value.h
Index: chrome/browser/extensions/extension_function_histogram_value.h
diff --git a/chrome/browser/extensions/extension_function_histogram_value.h
b/chrome/browser/extensions/extension_function_histogram_value.h
index
2bc33fca85d699299f6620d17023a6bb7dc8c4c4..8b4a5fe512abbe463a254991dfca5c7c2344a76e
100644
--- a/chrome/browser/extensions/extension_function_histogram_value.h
+++ b/chrome/browser/extensions/extension_function_histogram_value.h
@@ -570,6 +570,7 @@ enum HistogramValue {
   BOOKMARKMANAGERPRIVATE_REMOVETREES,
   SYSTEM_DISPLAY_GETINFO,
   SYSTEM_DISPLAY_SETDISPLAYPROPERTIES,
+  INFOBARS_SHOW,
   ENUM_BOUNDARY // Last entry: Add new entries above.
 };

[commit-bot: I haz the power, 2013-07-29 07:34:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/20081002/73001

[pals, 2013-07-29 07:41:19]

+hnguyen for chrome/test/webdriver/
Please review.

[pals, 2013-07-29 07:48:32]

+isherman for tools/
Please review the change.

[commit-bot: I haz the power, 2013-07-29 07:54:29]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Matt Perry, 2013-07-29 18:08:50]

https://codereview.chromium.org/20081002/diff/35001/AUTHORS
File AUTHORS (right):

https://codereview.chromium.org/20081002/diff/35001/AUTHORS#newcode220
AUTHORS:220: Sanjoy Pal <sanjoy.pal@samsung.com>
On 2013/07/29 06:04:04, sanjoyp wrote:
> On 2013/07/26 18:26:24, Matt Perry wrote:
> > Are you the same Sanjoy Pal? Pick one email address :)
> I have previously contributed from http://motorola.com email. Now, I joined
samsung. I
> don't have access to motorola email anymore. Should I remove motorola email
> because I see there are some duplicate emails for some people.

Yes, delete the motorola email.

[Ilya Sherman, 2013-07-29 22:48:53]

histograms.xml LGTM

[commit-bot: I haz the power, 2013-07-31 05:10:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/20081002/73001

[commit-bot: I haz the power, 2013-07-31 06:02:06]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-07-31 06:13:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/20081002/92001

[commit-bot: I haz the power, 2013-07-31 10:13:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/20081002/78002

[commit-bot: I haz the power, 2013-07-31 13:04:01]

Change committed as 214692

[Matt Perry, 2013-08-01 18:46:51]

Oops, noticed some mistakes in the docs.

https://codereview.chromium.org/20081002/diff/78002/chrome/common/extensions/...
File chrome/common/extensions/docs/templates/intros/experimental_infobars.html
(left):

https://codereview.chromium.org/20081002/diff/78002/chrome/common/extensions/...
chrome/common/extensions/docs/templates/intros/experimental_infobars.html:1: <p>
This file should have been renamed to intros/infobars.html

https://codereview.chromium.org/20081002/diff/78002/chrome/common/extensions/...
File chrome/common/extensions/docs/templates/intros/infobars.html (right):

https://codereview.chromium.org/20081002/diff/78002/chrome/common/extensions/...
chrome/common/extensions/docs/templates/intros/infobars.html:1:
{{+partials.standard_extensions_api api:apis.infobars intro:intros.infobars}}
This file belongs in templates/public/extensions/infobars.html