Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1274)

Issue 2008083002: Don't store resources with a unique key in GrResourceCache's fScratchMap (Closed)

Created:
4 years, 7 months ago by robertphillips
Modified:
4 years, 7 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Don't store resources with a unique key in GrResourceCache's fScratchMap The reasoning here is that resources with a unique key are never selected from fScratchMap and just clog up the search for an available resource. This knocks a 200x loop over the SVGbouncingrects case from 264ms down to 164ms. BUG=603969 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2008083002 Committed: https://skia.googlesource.com/skia/+/c4ed68426649dd4ca2c3119cdafdd562d3c3ba28

Patch Set 1 #

Patch Set 2 : clean up #

Patch Set 3 : clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -24 lines) Patch
M src/core/SkTMultiMap.h View 1 chunk +45 lines, -0 lines 0 comments Download
M src/gpu/GrResourceCache.cpp View 1 2 9 chunks +61 lines, -24 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
robertphillips
4 years, 7 months ago (2016-05-24 20:22:27 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008083002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008083002/40001
4 years, 7 months ago (2016-05-24 20:22:52 UTC) #8
bsalomon
Assuming this is covered adequately by existing unit tests, lgtm.
4 years, 7 months ago (2016-05-24 20:35:13 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-24 20:40:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008083002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008083002/40001
4 years, 7 months ago (2016-05-24 21:16:19 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 21:17:16 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/c4ed68426649dd4ca2c3119cdafdd562d3c3ba28

Powered by Google App Engine
This is Rietveld 408576698