Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2008073002: Refactor how TraceEventImporter identifies metadata fields (Closed)

Created:
4 years, 7 months ago by charliea (OOO until 10-5)
Modified:
4 years, 7 months ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Base URL:
git@github.com:catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 : #

Patch Set 2 : Fixes comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -15 lines) Patch
M tracing/tracing/extras/importer/trace_event_importer.html View 1 3 chunks +26 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
charliea (OOO until 10-5)
4 years, 7 months ago (2016-05-24 20:11:09 UTC) #4
nednguyen
lgtm
4 years, 7 months ago (2016-05-24 20:15:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008073002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008073002/60001
4 years, 7 months ago (2016-05-25 12:06:38 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 12:27:57 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698