Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2008063002: Add ScrollEnums.h, so that PaintLayerScrollableArea.h doesn't have to include LayoutBox.h (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
wkorman, eae, szager1
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, slimming-paint-reviews_chromium.org, dshwang, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ScrollEnums.h, so that PaintLayerScrollableArea.h doesn't have to include LayoutBox.h BUG=614015 Committed: https://crrev.com/2d0fc6a4eb6a5a2e29a7093e5a25e7853bfa69aa Cr-Commit-Position: refs/heads/master@{#395702}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -9 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBox.h View 2 chunks +1 line, -6 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ScrollEnums.h View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-05-24 21:21:25 UTC) #2
eae
LGTM
4 years, 7 months ago (2016-05-24 21:25:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008063002/1
4 years, 7 months ago (2016-05-24 21:26:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 21:35:12 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 21:37:49 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2d0fc6a4eb6a5a2e29a7093e5a25e7853bfa69aa
Cr-Commit-Position: refs/heads/master@{#395702}

Powered by Google App Engine
This is Rietveld 408576698