Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2008053002: Remove unnecessary inclusions of LayoutObject-derived headers in core/dom/ (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
eae
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary inclusions of LayoutObject-derived headers in core/dom/ BUG=614015 TBR=eae@chromium.org Committed: https://crrev.com/49b254f69d9bb8b345ec5a4638dcc38e763c8417 Cr-Commit-Position: refs/heads/master@{#395864}

Patch Set 1 #

Patch Set 2 : FirstLetterPseudoElement.cpp needs LayoutObjectInlines.h for LayoutObject::firstLineStyle() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M third_party/WebKit/Source/core/dom/IntersectionObservation.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/NodeRareData.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Range.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-05-25 11:10:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008053002/20001
4 years, 7 months ago (2016-05-25 11:10:43 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-25 11:35:58 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 11:37:15 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/49b254f69d9bb8b345ec5a4638dcc38e763c8417
Cr-Commit-Position: refs/heads/master@{#395864}

Powered by Google App Engine
This is Rietveld 408576698