Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2008043005: Fix incorrect learn more string for ERR_SSL_WEAK_SERVER_EPHEMERAL_DH_KEY (Closed)

Created:
4 years, 7 months ago by edwardjung
Modified:
4 years, 7 months ago
Reviewers:
mmenke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix incorrect learn more string for ERR_SSL_WEAK_SERVER_EPHEMERAL_DH_KEY This fixes the standalone_suggestion boolean logic of the AddLinkedSuggestionToList function which was coded incorrectly so it was reversed. BUG=614650 Committed: https://crrev.com/a95022ecf8841131224f263fe1b9c63ad53ecf80 Cr-Commit-Position: refs/heads/master@{#396235}

Patch Set 1 #

Patch Set 2 : Fix standalone_suggestion logic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M components/error_page/common/localized_error.cc View 1 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
mmenke
This ready for review? It LGTM, as-is. I missed a lot of stuff during review ...
4 years, 7 months ago (2016-05-26 16:15:00 UTC) #3
edwardjung
Yes, it is ready. Thanks. Not to worry, it was a fairly messy CL to ...
4 years, 7 months ago (2016-05-26 16:22:29 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008043005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008043005/20001
4 years, 7 months ago (2016-05-26 16:23:53 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-26 17:41:52 UTC) #8
commit-bot: I haz the power
Dry run: None
4 years, 7 months ago (2016-05-26 17:42:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008043005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008043005/20001
4 years, 7 months ago (2016-05-26 18:26:53 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-26 18:32:41 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 18:38:22 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a95022ecf8841131224f263fe1b9c63ad53ecf80
Cr-Commit-Position: refs/heads/master@{#396235}

Powered by Google App Engine
This is Rietveld 408576698