Chromium Code Reviews
Help | Chromium Project | Sign in
(245)

Issue 2008007: Replace about:net-internals with the javascript-based frontend.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 11 months ago by eroman
Modified:
2 years, 10 months ago
Reviewers:
willchan
CC:
chromium-reviews_chromium.org, cbentzel+watch_chromium.org, ben+cc_chromium.org, arv, pam+watch_chromium.org, PaweĊ‚ Hajdan Jr., darin-cc_chromium.org
Visibility:
Public.

Description

Replace about:net-internals with the javascript-based frontend.

(DNS request tracing is the only feature lost in this transition; it needs to be added back under the new framework).

BUG=37421
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46868

Patch Set 1 #

Patch Set 2 : improve a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -2897 lines) Lint Patch
M chrome/browser/browser_about_handler.cc View 1 chunk +2 lines, -3 lines 0 comments 0 errors Download
M chrome/browser/dom_ui/chrome_url_data_manager.cc View 2 chunks +4 lines, -4 lines 0 comments 0 errors Download
M chrome/browser/dom_ui/net_internals_ui.cc View 1 1 chunk +22 lines, -3 lines 0 comments 0 errors Download
A + chrome/browser/net/view_http_cache_job_factory.h View 1 chunk +4 lines, -4 lines 0 comments 1 errors Download
A + chrome/browser/net/view_http_cache_job_factory.cc View 3 chunks +18 lines, -831 lines 0 comments 0 errors Download
D chrome/browser/net/view_net_internals_job_factory.h View 1 chunk +0 lines, -18 lines 0 comments 0 errors Download
D chrome/browser/net/view_net_internals_job_factory.cc View 1 chunk +0 lines, -875 lines 0 comments 0 errors Download
M chrome/browser/resources/net_internals/httpcacheview.js View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -2 lines 0 comments 0 errors Download
M chrome/common/url_constants.cc View 2 chunks +2 lines, -3 lines 0 comments 0 errors Download
M net/base/host_resolver_impl.h View 3 chunks +0 lines, -14 lines 0 comments 0 errors Download
M net/base/host_resolver_impl.cc View 14 chunks +2 lines, -168 lines 0 comments 0 errors Download
M net/base/net_log.h View 1 chunk +1 line, -3 lines 0 comments 0 errors Download
D net/base/net_log_util.h View 1 chunk +0 lines, -76 lines 0 comments 0 errors Download
D net/base/net_log_util.cc View 1 chunk +0 lines, -235 lines 0 comments 0 errors Download
D net/base/net_log_util_unittest.cc View 1 chunk +0 lines, -132 lines 0 comments 0 errors Download
M net/net.gyp View 2 chunks +0 lines, -3 lines 0 comments 0 errors Download
D net/tools/dns_trace_formatter/formatter.py View 1 chunk +0 lines, -310 lines 0 comments 0 errors Download
D net/tools/dns_trace_formatter/parser.py View 1 chunk +0 lines, -139 lines 0 comments 0 errors Download
D net/tools/dns_trace_formatter/parser_test.py View 1 chunk +0 lines, -73 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 5
eroman
3 years, 11 months ago #1
willchan
On 2010/05/10 20:10:38, eroman wrote: > I haven't looked at this code yet, but I ...
3 years, 11 months ago #2
eroman
For copy-pasting, there is: chrome://net2#data (Make sure you are on ToT, because I only implemented ...
3 years, 11 months ago #3
eroman
> Also, the left pane doesn't seem to have a horizontal scrollbar. Actually, that was ...
3 years, 11 months ago #4
willchan
3 years, 11 months ago #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6