Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2007983006: Rename OwnPtr::clear() to reset() in modules/. (Closed)

Created:
4 years, 7 months ago by Yuta Kitamura
Modified:
4 years, 7 months ago
Reviewers:
haraken, *tzik
CC:
chromium-reviews, tzik, dshwang, mcasas+watch+mediarecorder_chromium.org, jsbell+serviceworker_chromium.org, toyoshim+midi_chromium.org, yhirano+watch_chromium.org, Justin Novosad, hongchan, Rik, blink-reviews, mcasas+watch+mediastream_chromium.org, Peter Beverloo, nhiroki, Raymond Toy, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, eric.carlson_apple.com, jsbell+idb_chromium.org, michaeln, tyoshino+watch_chromium.org, emircan+watch+mediarecorder_chromium.org, ajuma+watch-canvas_chromium.org, serviceworker-reviews, falken, mlamouri+watch-blink_chromium.org, kinuko+serviceworker, cmumford, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename OwnPtr::clear() to reset() in modules/. OwnPtr::clear() will soon get renamed to reset() as a part of OwnPtr-to-std::unique_ptr migration. BUG=611661 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/97c04786a05650b8a010b21eaa9bf1830b119900 Cr-Commit-Position: refs/heads/master@{#395916}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -68 lines) Patch
M third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/csspaint/PaintWorkletTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/CrossThreadHolder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchDataLoader.cpp View 11 chunks +21 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBCursor.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBCursor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediasource/MediaSource.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCDTMFSender.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCDataChannel.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationImageLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/PannerNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLTransactionBackend.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIAccess.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Yuta Kitamura
tzik: PTAL? +haraken for modules/ approval
4 years, 7 months ago (2016-05-25 06:01:15 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007983006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007983006/1
4 years, 7 months ago (2016-05-25 06:01:25 UTC) #6
tzik
lgtm
4 years, 7 months ago (2016-05-25 06:03:31 UTC) #7
haraken
LGTM
4 years, 7 months ago (2016-05-25 07:00:12 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/227714)
4 years, 7 months ago (2016-05-25 11:20:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007983006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007983006/1
4 years, 7 months ago (2016-05-25 12:06:58 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 17:12:33 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 17:13:37 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97c04786a05650b8a010b21eaa9bf1830b119900
Cr-Commit-Position: refs/heads/master@{#395916}

Powered by Google App Engine
This is Rietveld 408576698