[runtime] Fix number of literals for builtin functions.

[runtime] Fix number of literals for builtin functions.

This fixes the SharedFunctionInfo::num_literals field for global builtin
functions (e.g. {Object} and friends) to be accurate. The field was not
being updated by Runtime_SetCode. It also removes the dangerous and by
now obsolete JSFunction::NumberOfLiterals accessor.

R=mvstanton@chromium.org

Committed: https://crrev.com/7ca1f80d3124c6bb097aacda22676f61f1af373b
Cr-Commit-Position: refs/heads/master@{#36480}

[Michael Starzinger, 2016-05-24 14:20:26]

Description was changed from

==========
[runtime] Fix number of literals for builtin functions.

This fixes the SharedFunctionInfo::num_literals field for global builtin
functions (e.g. {Object} and friends) to be accurate. The number of
literals field in question was not being updated by Runtime_SetCode. It
also removes the dangerous JSFunction::NumberOfLiterals accessor which
has become obsolete by now.

R=mvstanton@chromium.org
==========

to

==========
[runtime] Fix number of literals for builtin functions.

This fixes the SharedFunctionInfo::num_literals field for global builtin
functions (e.g. {Object} and friends) to be accurate. The field was not
being updated by Runtime_SetCode. It also removes the dangerous and by
now obsolete JSFunction::NumberOfLiterals accessor.

R=mvstanton@chromium.org
==========

[mvstanton, 2016-05-24 14:35:09]

LGTM.

https://codereview.chromium.org/2007943002/diff/1/src/objects-inl.h
File src/objects-inl.h (left):

https://codereview.chromium.org/2007943002/diff/1/src/objects-inl.h#oldcode6245
src/objects-inl.h:6245: 
Two way to look something up === at least one broken.

https://codereview.chromium.org/2007943002/diff/1/src/objects-printer.cc
File src/objects-printer.cc (right):

https://codereview.chromium.org/2007943002/diff/1/src/objects-printer.cc#newc...
src/objects-printer.cc:919: os << "\n - num_literals = " << num_literals();
Thank you, I needed this too.

[Michael Starzinger, 2016-05-24 15:07:47]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2016-05-24 15:07:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvstanton@chromium.org
Link to the patchset: https://codereview.chromium.org/2007943002/#ps20001
(title: "Fix unittest.")

[commit-bot: I haz the power, 2016-05-24 15:07:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2007943002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2007943002/20001

[commit-bot: I haz the power, 2016-05-24 15:12:06]

Description was changed from

==========
[runtime] Fix number of literals for builtin functions.

This fixes the SharedFunctionInfo::num_literals field for global builtin
functions (e.g. {Object} and friends) to be accurate. The field was not
being updated by Runtime_SetCode. It also removes the dangerous and by
now obsolete JSFunction::NumberOfLiterals accessor.

R=mvstanton@chromium.org
==========

to

==========
[runtime] Fix number of literals for builtin functions.

This fixes the SharedFunctionInfo::num_literals field for global builtin
functions (e.g. {Object} and friends) to be accurate. The field was not
being updated by Runtime_SetCode. It also removes the dangerous and by
now obsolete JSFunction::NumberOfLiterals accessor.

R=mvstanton@chromium.org
==========

[commit-bot: I haz the power, 2016-05-24 15:12:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-24 15:13:06]

Description was changed from

==========
[runtime] Fix number of literals for builtin functions.

This fixes the SharedFunctionInfo::num_literals field for global builtin
functions (e.g. {Object} and friends) to be accurate. The field was not
being updated by Runtime_SetCode. It also removes the dangerous and by
now obsolete JSFunction::NumberOfLiterals accessor.

R=mvstanton@chromium.org
==========

to

==========
[runtime] Fix number of literals for builtin functions.

This fixes the SharedFunctionInfo::num_literals field for global builtin
functions (e.g. {Object} and friends) to be accurate. The field was not
being updated by Runtime_SetCode. It also removes the dangerous and by
now obsolete JSFunction::NumberOfLiterals accessor.

R=mvstanton@chromium.org

Committed: https://crrev.com/7ca1f80d3124c6bb097aacda22676f61f1af373b
Cr-Commit-Position: refs/heads/master@{#36480}
==========

[commit-bot: I haz the power, 2016-05-24 15:13:07]

Patchset 2 (id:??) landed as
https://crrev.com/7ca1f80d3124c6bb097aacda22676f61f1af373b
Cr-Commit-Position: refs/heads/master@{#36480}