Issue 2007933002: Revert "Revert "If an if or do statement always exits, following statements are dead.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2007933002: Revert "Revert "If an if or do statement always exits, following statements are dead."" (Closed)

Created:
4 years, 7 months ago by srawlins

Modified:
4 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Revert "If an if or do statement always exits, following statements are dead."" This reverts commit c0b0c7be81107070de7bdede41ff554253292a3d. BUG=https://github.com/dart-lang/sdk/issues/16420 R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/38e8d9702bb6a02fcb640a8c42044e7455892eeb

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -10 lines)			Patch
M	pkg/analyzer/lib/src/generated/resolver.dart	View	1 chunk	+11 lines, -8 lines	0 comments	Download
M	pkg/analyzer/test/generated/hint_code_test.dart	View	3 chunks	+17 lines, -2 lines	0 comments	Download
M	pkg/analyzer/test/generated/non_hint_code_test.dart	View	1 chunk	+13 lines, -0 lines	0 comments	Download

Total messages: 4 (2 generated)

Brian Wilkerson

lgtm, assuming you've run it over ddc and there aren't any false positives.

4 years, 7 months ago (2016-05-24 14:46:37 UTC) #2

srawlins

4 years, 6 months ago (2016-06-02 22:25:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
38e8d9702bb6a02fcb640a8c42044e7455892eeb (presubmit successful).