Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2007873002: Gerrit git cl upload: obey -s --send-mail option. (Closed)

Created:
4 years, 7 months ago by tandrii(chromium)
Modified:
4 years, 7 months ago
Reviewers:
Bons
CC:
chromium-reviews, tandrii+omg_git_cl_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Gerrit git cl upload: obey -s --send-mail option. Previously, git cl upload would send email every time. This CL changes that to send email only if -s or --send-mail is given. R=andybons@chromium.org BUG=612728 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300662

Patch Set 1 #

Patch Set 2 : shorter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -10 lines) Patch
M git_cl.py View 2 chunks +7 lines, -1 line 0 comments Download
M tests/git_cl_test.py View 1 5 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
tandrii(chromium)
4 years, 7 months ago (2016-05-24 09:07:08 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007873002/1
4 years, 7 months ago (2016-05-24 09:07:08 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Depot Tools Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubmit/builds/482)
4 years, 7 months ago (2016-05-24 09:13:19 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007873002/20001
4 years, 7 months ago (2016-05-24 09:16:18 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-24 09:19:09 UTC) #9
Bons
lgtm
4 years, 7 months ago (2016-05-24 15:24:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2007873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2007873002/20001
4 years, 7 months ago (2016-05-24 23:07:48 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 23:11:05 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300662

Powered by Google App Engine
This is Rietveld 408576698