Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Side by Side Diff: BUILD.gn

Issue 2007843002: [gn] Make v8_target_arch a GN declare_arg() (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Review Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build_overrides/v8.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/arm.gni") 6 import("//build/config/arm.gni")
7 import("//build/config/mips.gni") 7 import("//build/config/mips.gni")
8 import("//build/config/sanitizers/sanitizers.gni") 8 import("//build/config/sanitizers/sanitizers.gni")
9 9
10 if (is_android) { 10 if (is_android) {
11 import("//build/config/android/rules.gni") 11 import("//build/config/android/rules.gni")
12 } 12 }
13 13
14 # Because standalone V8 builds are not supported, assume this is part of a 14 import("gni/v8.gni")
15 # Chromium build.
16 import("//build_overrides/v8.gni") 15 import("//build_overrides/v8.gni")
17 16
18 import("snapshot_toolchain.gni") 17 import("snapshot_toolchain.gni")
19 18
20 declare_args() { 19 declare_args() {
21 # Enable the snapshot feature, for fast context creation. 20 # Enable the snapshot feature, for fast context creation.
22 # http://v8project.blogspot.com/2015/09/custom-startup-snapshots.html 21 # http://v8project.blogspot.com/2015/09/custom-startup-snapshots.html
23 v8_use_snapshot = true 22 v8_use_snapshot = true
24 23
25 # Use external files for startup data blobs: 24 # Use external files for startup data blobs:
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 # Similar to vfp but on MIPS. 62 # Similar to vfp but on MIPS.
64 v8_can_use_fpu_instructions = true 63 v8_can_use_fpu_instructions = true
65 64
66 # Similar to the ARM hard float ABI but on MIPS. 65 # Similar to the ARM hard float ABI but on MIPS.
67 v8_use_mips_abi_hardfloat = true 66 v8_use_mips_abi_hardfloat = true
68 } 67 }
69 68
70 v8_random_seed = "314159265" 69 v8_random_seed = "314159265"
71 v8_toolset_for_shell = "host" 70 v8_toolset_for_shell = "host"
72 71
73 if (is_msan) { 72 if (v8_target_arch == "") {
74 # Running the V8-generated code on an ARM simulator is a powerful hack that 73 if (is_msan) {
75 # allows the tool to see the memory accesses from JITted code. Without this 74 # Running the V8-generated code on an ARM simulator is a powerful hack that
76 # flag, JS code causes false positive reports from MSan. 75 # allows the tool to see the memory accesses from JITted code. Without this
77 v8_target_arch = "arm64" 76 # flag, JS code causes false positive reports from MSan.
78 } else { 77 v8_target_arch = "arm64"
79 v8_target_arch = target_cpu 78 } else {
79 v8_target_arch = target_cpu
80 }
80 } 81 }
81 82
82 if (v8_use_snapshot && v8_use_external_startup_data) { 83 if (v8_use_snapshot && v8_use_external_startup_data) {
83 snapshot_target = ":v8_external_snapshot" 84 snapshot_target = ":v8_external_snapshot"
84 } else if (v8_use_snapshot) { 85 } else if (v8_use_snapshot) {
85 snapshot_target = ":v8_snapshot" 86 snapshot_target = ":v8_snapshot"
86 } else { 87 } else {
87 assert(!v8_use_external_startup_data) 88 assert(!v8_use_external_startup_data)
88 snapshot_target = ":v8_nosnapshot" 89 snapshot_target = ":v8_nosnapshot"
89 } 90 }
(...skipping 2100 matching lines...) Expand 10 before | Expand all | Expand 10 after
2190 sources = [ 2191 sources = [
2191 "test/fuzzer/wasm-asmjs.cc", 2192 "test/fuzzer/wasm-asmjs.cc",
2192 ] 2193 ]
2193 2194
2194 deps = [ 2195 deps = [
2195 ":fuzzer_support", 2196 ":fuzzer_support",
2196 ] 2197 ]
2197 2198
2198 configs = [ ":internal_config" ] 2199 configs = [ ":internal_config" ]
2199 } 2200 }
OLDNEW
« no previous file with comments | « no previous file | build_overrides/v8.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698