[gn] Make v8_target_arch a GN declare_arg()

[gn] Make v8_target_arch a GN declare_arg()

There are bots on the chromium.lkgr waterfall that need to
be able to set v8_target_arch to "arm" while the rest of
the target build is "x86". This CL makes that argument
a declare_arg(), so that we can do that.

BUG=chromium:605732, chromium:474921
NOTRY=true

Committed: https://crrev.com/3be95b712c2f5acfb189b60cb3e4ba3600a66ba8
Cr-Commit-Position: refs/heads/master@{#36464}

[Michael Achenbach, 2016-05-24 07:48:26]

Description was changed from

==========
[gn] Make v8_target_arch a GN declare_arg()

BUG=
==========

to

==========
[gn] Make v8_target_arch a GN declare_arg()

There are bots on the chromium.lkgr waterfall that need to
be able to set v8_target_arch to "arm" while the rest of
the target build is "x86". This CL makes that argument
a declare_arg(), so that we can do that.

BUG=chromium:605732
==========

[Michael Achenbach, 2016-05-24 07:50:11]

Description was changed from

==========
[gn] Make v8_target_arch a GN declare_arg()

There are bots on the chromium.lkgr waterfall that need to
be able to set v8_target_arch to "arm" while the rest of
the target build is "x86". This CL makes that argument
a declare_arg(), so that we can do that.

BUG=chromium:605732
==========

to

==========
[gn] Make v8_target_arch a GN declare_arg()

There are bots on the chromium.lkgr waterfall that need to
be able to set v8_target_arch to "arm" while the rest of
the target build is "x86". This CL makes that argument
a declare_arg(), so that we can do that.

BUG=chromium:605732,chromium:474921
==========

[Michael Achenbach, 2016-05-24 08:14:09]

machenbach@chromium.org changed reviewers:
+ dpranke@chromium.org, vogelheim@chromium.org

[Michael Achenbach, 2016-05-24 08:14:09]

PTAL. Borrowed and adapted https://codereview.chromium.org/2006163004/ to also
work with v8 stand-alone.

[Michael Achenbach, 2016-05-24 08:14:20]

Description was changed from

==========
[gn] Make v8_target_arch a GN declare_arg()

There are bots on the chromium.lkgr waterfall that need to
be able to set v8_target_arch to "arm" while the rest of
the target build is "x86". This CL makes that argument
a declare_arg(), so that we can do that.

BUG=chromium:605732,chromium:474921
==========

to

==========
[gn] Make v8_target_arch a GN declare_arg()

There are bots on the chromium.lkgr waterfall that need to
be able to set v8_target_arch to "arm" while the rest of
the target build is "x86". This CL makes that argument
a declare_arg(), so that we can do that.

BUG=chromium:605732,chromium:474921
NOTRY=true
==========

[vogelheim, 2016-05-24 08:31:27]

lgtm

https://codereview.chromium.org/2007843002/diff/20001/gni/v8.gni
File gni/v8.gni (right):

https://codereview.chromium.org/2007843002/diff/20001/gni/v8.gni#newcode7
gni/v8.gni:7: # target_arch, a simulator will be run.
target_arch => target_cpu ??

(Not sure if there's a difference, but this CL only refers to target_cpu.)

[Michael Achenbach, 2016-05-24 08:52:31]

https://codereview.chromium.org/2007843002/diff/20001/gni/v8.gni
File gni/v8.gni (right):

https://codereview.chromium.org/2007843002/diff/20001/gni/v8.gni#newcode7
gni/v8.gni:7: # target_arch, a simulator will be run.
On 2016/05/24 08:31:27, vogelheim wrote:
> target_arch => target_cpu ??
> 
> (Not sure if there's a difference, but this CL only refers to target_cpu.)

Done.

[Michael Achenbach, 2016-05-24 08:52:41]

The CQ bit was checked by machenbach@chromium.org

[Michael Achenbach, 2016-05-24 08:52:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/2007843002/#ps40001
(title: "Review")

[commit-bot: I haz the power, 2016-05-24 08:52:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2007843002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2007843002/40001

[commit-bot: I haz the power, 2016-05-24 08:54:50]

Description was changed from

==========
[gn] Make v8_target_arch a GN declare_arg()

There are bots on the chromium.lkgr waterfall that need to
be able to set v8_target_arch to "arm" while the rest of
the target build is "x86". This CL makes that argument
a declare_arg(), so that we can do that.

BUG=chromium:605732,chromium:474921
NOTRY=true
==========

to

==========
[gn] Make v8_target_arch a GN declare_arg()

There are bots on the chromium.lkgr waterfall that need to
be able to set v8_target_arch to "arm" while the rest of
the target build is "x86". This CL makes that argument
a declare_arg(), so that we can do that.

BUG=chromium:605732,chromium:474921
NOTRY=true
==========

[commit-bot: I haz the power, 2016-05-24 08:54:51]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-24 08:55:42]

Description was changed from

==========
[gn] Make v8_target_arch a GN declare_arg()

There are bots on the chromium.lkgr waterfall that need to
be able to set v8_target_arch to "arm" while the rest of
the target build is "x86". This CL makes that argument
a declare_arg(), so that we can do that.

BUG=chromium:605732,chromium:474921
NOTRY=true
==========

to

==========
[gn] Make v8_target_arch a GN declare_arg()

There are bots on the chromium.lkgr waterfall that need to
be able to set v8_target_arch to "arm" while the rest of
the target build is "x86". This CL makes that argument
a declare_arg(), so that we can do that.

BUG=chromium:605732,chromium:474921
NOTRY=true

Committed: https://crrev.com/3be95b712c2f5acfb189b60cb3e4ba3600a66ba8
Cr-Commit-Position: refs/heads/master@{#36464}
==========

[commit-bot: I haz the power, 2016-05-24 08:55:43]

Patchset 3 (id:??) landed as
https://crrev.com/3be95b712c2f5acfb189b60cb3e4ba3600a66ba8
Cr-Commit-Position: refs/heads/master@{#36464}

[Michael Achenbach, 2016-05-24 09:59:02]

Follow up fix:
https://codereview.chromium.org/2006213002/

[Dirk Pranke, 2016-05-24 18:46:11]

lgtm along w/ the follow-up if my comments in the follow-up are correct.